Skip to content

Commit 0d34d62

Browse files
akpm00sfrothwell
authored andcommitted
mm-page_alloc-rename-__gfp_wait-to-__gfp_reclaim-checkpatch-fixes
WARNING: line over 80 characters torvalds#110: FILE: drivers/block/drbd/drbd_bitmap.c:1010: + page = mempool_alloc(drbd_md_io_page_pool, __GFP_HIGHMEM|__GFP_RECLAIM); WARNING: line over 80 characters torvalds#139: FILE: drivers/block/nvme-core.c:1039: + ret = blk_rq_map_user(q, req, NULL, ubuffer, bufflen, __GFP_RECLAIM); WARNING: line over 80 characters torvalds#466: FILE: include/linux/gfp.h:110: +#define __GFP_RECLAIM ((__force gfp_t)(___GFP_DIRECT_RECLAIM|___GFP_KSWAPD_RECLAIM)) ERROR: code indent should use tabs where possible torvalds#547: FILE: kernel/power/swap.c:978: +^I^I __get_free_page(__GFP_RECLAIM | __GFP_HIGH);$ ERROR: code indent should use tabs where possible torvalds#557: FILE: kernel/power/swap.c:1245: +^I^I __GFP_RECLAIM | __GFP_HIGH :$ ERROR: code indent should use tabs where possible torvalds#558: FILE: kernel/power/swap.c:1246: +^I^I __GFP_RECLAIM | __GFP_NOWARN |$ WARNING: line over 80 characters torvalds#570: FILE: lib/percpu_ida.c:138: + * used for internal memory allocations); thus if passed __GFP_RECLAIM we may sleep ERROR: code indent should use tabs where possible torvalds#596: FILE: mm/failslab.c:19: + if (failslab.ignore_gfp_reclaim && (gfpflags & __GFP_RECLAIM))$ WARNING: please, no spaces at the start of a line torvalds#596: FILE: mm/failslab.c:19: + if (failslab.ignore_gfp_reclaim && (gfpflags & __GFP_RECLAIM))$ WARNING: line over 80 characters torvalds#617: FILE: mm/filemap.c:2717: + * this page (__GFP_IO), and whether the call may block (__GFP_RECLAIM & __GFP_FS). total: 4 errors, 6 warnings, 463 lines checked NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/mm-page_alloc-rename-__gfp_wait-to-__gfp_reclaim.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Mel Gorman <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent f43052a commit 0d34d62

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

kernel/power/swap.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -975,7 +975,7 @@ static int get_swap_reader(struct swap_map_handle *handle,
975975
last = tmp;
976976

977977
tmp->map = (struct swap_map_page *)
978-
__get_free_page(__GFP_RECLAIM | __GFP_HIGH);
978+
__get_free_page(__GFP_RECLAIM | __GFP_HIGH);
979979
if (!tmp->map) {
980980
release_swap_reader(handle);
981981
return -ENOMEM;
@@ -1242,9 +1242,9 @@ static int load_image_lzo(struct swap_map_handle *handle,
12421242

12431243
for (i = 0; i < read_pages; i++) {
12441244
page[i] = (void *)__get_free_page(i < LZO_CMP_PAGES ?
1245-
__GFP_RECLAIM | __GFP_HIGH :
1246-
__GFP_RECLAIM | __GFP_NOWARN |
1247-
__GFP_NORETRY);
1245+
__GFP_RECLAIM | __GFP_HIGH :
1246+
__GFP_RECLAIM | __GFP_NOWARN |
1247+
__GFP_NORETRY);
12481248

12491249
if (!page[i]) {
12501250
if (i < LZO_CMP_PAGES) {

mm/failslab.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ bool should_failslab(size_t size, gfp_t gfpflags, unsigned long cache_flags)
1616
if (gfpflags & __GFP_NOFAIL)
1717
return false;
1818

19-
if (failslab.ignore_gfp_reclaim && (gfpflags & __GFP_RECLAIM))
19+
if (failslab.ignore_gfp_reclaim && (gfpflags & __GFP_RECLAIM))
2020
return false;
2121

2222
if (failslab.cache_filter && !(cache_flags & SLAB_FAILSLAB))

0 commit comments

Comments
 (0)