-
-
Notifications
You must be signed in to change notification settings - Fork 234
[Feature Request] Provide more information about blocked domain #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If I remember correctly the lists are aggregated per group. 🤔 So it would be quite troublesome gathering the information if the entry is duplicate in multiple lists in the same group. I assume you'd like to get all lists with the entry? Wouldn't splitting your lists in multiple groups and using all of them as your block groups be more readable? |
Indeed, storing the list(s) a url is blocked by would increase RAM usage a fair bit. Maybe adding a subcommand to blocky that downloads and parses the configured lists, and then prints the ones that block a specific domain would be a good approach. |
As mentioned by @kwitsch and @ThinkChaos , the workaround is to define one url per group. I think, we could change the internal cache representation to provide more detailed information. Maybe internal a cache struct per url or storing a additional byte with list order? |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
😅 |
I'm thinking we should probably move towards having a CLI command like |
CLI uses currently only the REST API and doesn't contain any logic. I think we can use existing cache and provide calculated result over the API |
Will be helpful to tell the exact block list(s) that being the reason a certain domain being blocked, like Pi-Hole:
Right now we can only know the "group", but there could be many blocklists in a single group, if you want to find out which one is the one, that'll be pretty hard:
The text was updated successfully, but these errors were encountered: