fix: Don't use a macro to generate Action debug helper function #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to AccessKit/accesskit-c#8
We can't unfortunately use a macro when generating public types in the common crate: cbindgen will exclude them from the header file by default and telling it to expand the common crate is not possible AFAIK.
I've manually implemented a method similar to what the enumn crate would generate. The function which does the convertion from a mask to a list of actions doesn't rely on a manually provided upper bound, so the only place we would have to update if the enum change is the
Action::nmethod. I don't think we can do better.