Skip to content

Remove (OLED) from "Pure dark (OLED)" #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Apr 1, 2025 · 10 comments
Closed

Remove (OLED) from "Pure dark (OLED)" #203

ghost opened this issue Apr 1, 2025 · 10 comments
Assignees
Labels
🚀 Feature request New feature request or improvement

Comments

@ghost
Copy link

ghost commented Apr 1, 2025

Since you don't need an OLED display to use it. Maybe call it pure black instead of pure dark too.

@Acclorite
Copy link
Owner

I don't see issues with current naming and "(OLED)" part is just a bit more clearer indicator of darker theme. As for "pure black", the app has "dark" theme, not "black" theme, so why name it "pure black" and not "pure dark"?

@Acclorite Acclorite closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2025
@Acclorite Acclorite added the 😔 Will not do Will not be implemented/fixed due to specified reasons (in most cases) label Apr 1, 2025
@ghost
Copy link
Author

ghost commented Apr 1, 2025

I don't see issues with current naming and "(OLED)" part is just a bit more clearer indicator of darker theme. As for "pure black", the app has "dark" theme, not "black" theme, so why name it "pure black" and not "pure dark"?

OLED (organic light-emitting diode) is a screen technology, not a theme. OLED in itself does not mean "dark". The battery savings of a pure black dark theme compared to a gray dark theme are very small: https://www.xda-developers.com/amoled-black-vs-gray-dark-mode. "Pure dark" should be self-explanatory enough.

@ghost
Copy link
Author

ghost commented Apr 1, 2025

I don't see issues with current naming and "(OLED)" part is just a bit more clearer indicator of darker theme. As for "pure black", the app has "dark" theme, not "black" theme, so why name it "pure black" and not "pure dark"?

Also, how is "(OLED)" a clearer indicator of a darker theme?

@Acclorite
Copy link
Owner

Also, how is "(OLED)" a clearer indicator of a darker theme?

Because some users expect "OLED" to mean "dark". Look at most apps, "OLED" mode usually means completely black theme. By definition? It is not.

OLED (organic light-emitting diode) is a screen technology, not a theme.

No, but this screen technology's ability to completely turn off pixels, emitting no light, explains why "OLED" is used in the naming.

OLED in itself does not mean "dark"

Not in itself, but it can be "dark".

The battery savings of a pure black dark theme compared to a gray dark theme are very small

It doesn't change the fact of me getting request to implement 0x000000 (black) theme (#64).

If I remove "OLED" or this theme completely I will just get another feature request for it. If user is happy with this theme, why remove or change its naming?

@ghost
Copy link
Author

ghost commented Apr 1, 2025

Because a theme is associated with something mostly unrelated? That should be avoided. I don't think many people will mind. Many mainstream apps with pure black themes have the theme just called "black", "pure black" or something similar and they probably don't have anyone complaining about the darker dark mode not mentioning some screen technology (or at least not many people).

What if someone thinks "OLED" means they need an OLED display to turn on the option?

@Acclorite
Copy link
Owner

Because a theme is associated with something mostly unrelated? That should be avoided. I don't think many people will mind. Many mainstream apps with pure black themes have the theme just called "black", "pure black" or something similar and they probably don't have anyone complaining about the darker dark mode not mentioning some screen technology.

You are a user, if it really irritates you then sure, I will remove that. At least until someone creates an issue to return it.

@Acclorite Acclorite reopened this Apr 1, 2025
@Acclorite Acclorite added 🚀 Feature request New feature request or improvement and removed 😔 Will not do Will not be implemented/fixed due to specified reasons (in most cases) labels Apr 1, 2025
@Acclorite Acclorite self-assigned this Apr 1, 2025
@Acclorite Acclorite moved this to In progress in Book's Story: Roadmap 🌌 Apr 1, 2025
@Acclorite Acclorite added this to the UI Improvement milestone Apr 1, 2025
@ghost
Copy link
Author

ghost commented Apr 1, 2025

Because a theme is associated with something mostly unrelated? That should be avoided. I don't think many people will mind. Many mainstream apps with pure black themes have the theme just called "black", "pure black" or something similar and they probably don't have anyone complaining about the darker dark mode not mentioning some screen technology.

You are a user, if it really irritates you then sure, I will remove that. At least until someone creates an issue to return it.

Thanks!
Lets just hope no one creates an issue about it, right? :)

@irbox
Copy link

irbox commented Apr 8, 2025

Title: Unified Dark theme option and/or Refactor "Pure Dark (OLED)" section into a Battery Saver mode

Description:

Current Problem:

The "Pure Dark (OLED)" Segmented buttons section feels redundant and separate from the main Dark theme configuration. This separation adds visual clutter and breaks UX consistency.

Proposed Changes:

  1. Remove the separate "Pure Dark (OLED)" segmented button section.
  2. Integrate a "Black" option into the existing Dark theme Segmented buttons section (above the "App theme" section).
  3. Alternative approach (optional but recommended):
    • Repurpose the current "Pure Dark (OLED)" section into a "Battery Saver Mode" section.
    • Include options: Enable, Disable, and Auto/System.
    • This mode would do more than switch to black—it would also disable power-intensive features/processes within the app.
    • This is particularly beneficial for users in regions with frequent power outages or limited access to charging.

Justification:

  • Improves UX by reducing fragmentation in theme settings.
  • Makes better use of existing UI space and reduces cognitive load.
  • Battery Saver Mode adds meaningful functionality for power-conscious users and aligns with accessibility and sustainability goals.

@irbox
Copy link

irbox commented Apr 8, 2025

I saw this issue in "In progress" section in the Project tab, so I just added my suggestion here, instead of creating a new issue. I hope it helps.

@Acclorite
Copy link
Owner

Integrate a "Black" option into the existing Dark theme Segmented buttons section (above the "App theme" section).

What if user has it set to "System", how to define if it should be "black" or "dark"?

Repurpose the current "Pure Dark (OLED)" section into a "Battery Saver Mode" section.

"Pure dark" is not a "power saver" theme but black theme. "Saver" is just one of it's options. I personally use it because I like it, not to save battery or increase performance.

This mode would do more than switch to black—it would also disable power-intensive features/processes within the app.

I would not like to use a theme only without animations. Why not make "Battery saver mode" a separate option to only disable power-intensive features, so users can use whatever theme they like while also keeping animations off (it would also help those with old devices)?

@github-project-automation github-project-automation bot moved this from In progress to Done in Book's Story: Roadmap 🌌 Apr 22, 2025
@Acclorite Acclorite added ⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release and removed ⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature request or improvement
Projects
Status: Done
Development

No branches or pull requests

2 participants