-
-
Notifications
You must be signed in to change notification settings - Fork 44
Remove (OLED) from "Pure dark (OLED)" #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't see issues with current naming and "(OLED)" part is just a bit more clearer indicator of darker theme. As for "pure black", the app has "dark" theme, not "black" theme, so why name it "pure black" and not "pure dark"? |
OLED (organic light-emitting diode) is a screen technology, not a theme. OLED in itself does not mean "dark". The battery savings of a pure black dark theme compared to a gray dark theme are very small: https://www.xda-developers.com/amoled-black-vs-gray-dark-mode. "Pure dark" should be self-explanatory enough. |
Also, how is "(OLED)" a clearer indicator of a darker theme? |
Because some users expect "OLED" to mean "dark". Look at most apps, "OLED" mode usually means completely black theme. By definition? It is not.
No, but this screen technology's ability to completely turn off pixels, emitting no light, explains why "OLED" is used in the naming.
Not in itself, but it can be "dark".
It doesn't change the fact of me getting request to implement 0x000000 (black) theme (#64). If I remove "OLED" or this theme completely I will just get another feature request for it. If user is happy with this theme, why remove or change its naming? |
Because a theme is associated with something mostly unrelated? That should be avoided. I don't think many people will mind. Many mainstream apps with pure black themes have the theme just called "black", "pure black" or something similar and they probably don't have anyone complaining about the darker dark mode not mentioning some screen technology (or at least not many people). What if someone thinks "OLED" means they need an OLED display to turn on the option? |
You are a user, if it really irritates you then sure, I will remove that. At least until someone creates an issue to return it. |
Thanks! |
Title: Unified Dark theme option and/or Refactor "Pure Dark (OLED)" section into a Battery Saver mode Description: Current Problem:The "Pure Dark (OLED)" Segmented buttons section feels redundant and separate from the main Dark theme configuration. This separation adds visual clutter and breaks UX consistency. Proposed Changes:
Justification:
|
I saw this issue in "In progress" section in the Project tab, so I just added my suggestion here, instead of creating a new issue. I hope it helps. |
What if user has it set to "System", how to define if it should be "black" or "dark"?
"Pure dark" is not a "power saver" theme but black theme. "Saver" is just one of it's options. I personally use it because I like it, not to save battery or increase performance.
I would not like to use a theme only without animations. Why not make "Battery saver mode" a separate option to only disable power-intensive features, so users can use whatever theme they like while also keeping animations off (it would also help those with old devices)? |
Since you don't need an OLED display to use it. Maybe call it pure black instead of pure dark too.
The text was updated successfully, but these errors were encountered: