PHP 8.4 support

Author: Alanaktion

app/controller/api.php

@@ -9,7 +9,7 @@ abstract class Api extends \Controller
     public function __construct()
     {
         $f3 = \Base::instance();
-        $f3->set("ONERROR", function (\Base $f3) {
+        $f3->set("ONERROR", function (\Base $f3): void {
             if (!headers_sent()) {
                 header("Content-type: application/json");
             }

app/controller/issues.php

@@ -1005,7 +1005,7 @@ public function single_related($f3, $params)
         $orderParams = ["order" => "status_closed, priority DESC, due_date"];
         $f3->set("issues", $issues->find($searchParams, $orderParams));
 
-        $searchParams[0] = $searchParams[0] . " AND status_closed = 0";
+        $searchParams[0] .= " AND status_closed = 0";
         $openIssues = $issues->count($searchParams);
 
         $this->_printJson([

app/controller/issues/project.php

@@ -57,7 +57,7 @@ public function overview($f3, $params)
          * @param   int          $level
          * @var     callable $renderTree This function, required for recursive calls
          */
-        $renderTree = function (\Model\Issue &$issue, $level = 0) use ($parentMap, &$renderTree) {
+        $renderTree = function (\Model\Issue &$issue, $level = 0) use ($parentMap, &$renderTree): void {
             if ($issue->id) {
                 $f3 = \Base::instance();
                 $children = $parentMap[$issue->id] ?? [];

app/helper/dashboard.php

@@ -261,7 +261,7 @@ public function issue_tree()
          * @param   array $issue
          * @var     callable $renderTree This function, required for recursive calls
          */
-        $renderTree = function (&$issue, $level = 0) use (&$renderTree) {
+        $renderTree = function (&$issue, $level = 0) use (&$renderTree): void {
             if (!empty($issue['id'])) {
                 $f3 = \Base::instance();
                 $hive = ["issue" => $issue, "dict" => $f3->get("dict"), "BASE" => $f3->get("BASE"), "level" => $level, "issue_type" => $f3->get("issue_type")];

app/helper/view.php

@@ -28,7 +28,7 @@ public function parseText($str, $options = [], $ttl = null)
         if ($options === null) {
             $options = [];
         }
-        $options = $options + \Base::instance()->get("parse");
+        $options += \Base::instance()->get("parse");
 
         // Check for cached value if $ttl is set
         $cache = \Cache::instance();

app/model/config.php

@@ -54,7 +54,7 @@ public static function importAll()
 
         // Import existing config
         $ini = parse_ini_file($root . "/config.ini");
-        $ini = $ini + parse_ini_file($root . "/config-base.ini");
+        $ini += parse_ini_file($root . "/config-base.ini");
         foreach ($ini as $key => $val) {
             if (substr($key, 0, 3) == "db.") {
                 continue;

app/model/issue.php

@@ -571,7 +571,7 @@ public function descendantIds(): array
         $ids = [$this->id];
         foreach ($this->getChildren() as $child) {
             $ids[] = $child->id;
-            $ids = $ids + $child->descendantIds();
+            $ids += $child->descendantIds();
         }
         return array_unique($ids);
     }

app/view/admin/index.html

@@ -42,7 +42,7 @@ <h4>{{ @dict.database }}</h4>
             <b>{{ @dict.username }}:</b> {{ @db.user | esc }}<br>
             <b>{{ @dict.password }}:</b> ********<br>
             <b>{{ @dict.current_version }}:</b> {{@version}}<br>
-            <b>MySQL version:</b> {{ @db.instance->getAttribute(\PDO::ATTR_SERVER_VERSION) }}
+            <b>MySQL:</b> {{ @db.instance->getAttribute(\PDO::ATTR_SERVER_VERSION) }}
         </div>
         <div class="col-md-3 col-sm-6">
             <div class="clearfix">
@@ -84,6 +84,7 @@ <h4>{{ @dict.incoming_mail }}</h4>
         <div class="col-md-3 col-sm-6">
             <h4>{{ @dict.miscellaneous }}</h4>
             <p>
+                <b>PHP:</b> {{ phpversion() }}<br>
                 <b>{{ @dict.debug_level }}:</b> {{ @DEBUG }}<br>
                 <b>{{ @dict.session_lifetime }}:</b> {{ gmdate("z\\d G\\h", @JAR.expire) }}<br>
                 <b>{{ @dict.max_upload_size }}:</b> {{ round(@files.maxsize/1024/1024, 2) }}MB

composer.json

@@ -24,6 +24,6 @@
     },
     "require-dev": {
         "squizlabs/php_codesniffer": "3.*",
-        "rector/rector": "^0.15"
+        "rector/rector": "^2.0"
     }
 }