Fixed border-style #34

FlorianRappl · FlorianRappl · commit 275b0f4d3a60 · 2019-05-28T22:07:00.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 - Added `GetMatchingStyles` extension for `ICssRuleList`
 - Added `MinifyStyleFormatter`
 - Added `Prettify` and `Minify` extension methods
+- Fixed border-style expansion order (#34)
 
 # 0.12.1
 
diff --git a/src/AngleSharp.Css.Tests/Declarations/CssBorderProperty.cs b/src/AngleSharp.Css.Tests/Declarations/CssBorderProperty.cs
@@ -3,6 +3,7 @@
 
 namespace AngleSharp.Css.Tests.Declarations
 {
+    using AngleSharp.Dom;
     using NUnit.Framework;
     using static CssConstructionFunctions;
 
@@ -244,6 +245,22 @@ public void CssBorderStyleHiddenDottedNoneNoneLegal()
             Assert.AreEqual("hidden dotted none none", property.Value);
         }
 
+        [Test]
+        public void CssBorderStyleMultipleExpandCorrectly_Issue34()
+        {
+            var source = @"<!DOCTYPE html>
+<html>
+<head><title></title></head>
+<body style=""border-style: hidden double dashed;""></body>
+</html>";
+            var document = source.ToHtmlDocument(Configuration.Default.WithCss());
+            var styleDeclaration = document.Body.ComputeCurrentStyle();
+            Assert.AreEqual("hidden", styleDeclaration.GetBorderTopStyle());
+            Assert.AreEqual("double", styleDeclaration.GetBorderLeftStyle());
+            Assert.AreEqual("double", styleDeclaration.GetBorderRightStyle());
+            Assert.AreEqual("dashed", styleDeclaration.GetBorderBottomStyle());
+        }
+
         [Test]
         public void CssBorderStyleWavyIllegal()
         {
diff --git a/src/AngleSharp.Css/Declarations/BorderStyleDeclaration.cs b/src/AngleSharp.Css/Declarations/BorderStyleDeclaration.cs
@@ -21,8 +21,8 @@ static class BorderStyleDeclaration
 
         public static String[] Longhands = new[]
         {
-            PropertyNames.BorderRightStyle,
             PropertyNames.BorderTopStyle,
+            PropertyNames.BorderRightStyle,
             PropertyNames.BorderBottomStyle,
             PropertyNames.BorderLeftStyle,
         };

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@ static class BorderStyleDeclaration`
`21`	`21`
`22`	`22`	`public static String[] Longhands = new[]`
`23`	`23`	`{`
`24`		`- PropertyNames.BorderRightStyle,`
`25`	`24`	`PropertyNames.BorderTopStyle,`
	`25`	`+ PropertyNames.BorderRightStyle,`
`26`	`26`	`PropertyNames.BorderBottomStyle,`
`27`	`27`	`PropertyNames.BorderLeftStyle,`
`28`	`28`	`};`