Skip to content

Commit 5694c9b

Browse files
egilegil
committed
release v1.0.0
# Conflicts: # CHANGELOG.md # src/AngleSharp.Diffing.Tests/Core/HtmlDifferenceEngineTest.cs # src/AngleSharp.Diffing/Core/AttributeComparison.cs # src/AngleSharp.Diffing/Core/AttributeComparisonSource.cs # src/AngleSharp.Diffing/Core/CompareDecision.cs # src/AngleSharp.Diffing/Core/CompareResult.cs # src/AngleSharp.Diffing/Core/Comparison.cs # src/AngleSharp.Diffing/Core/ComparisonSource.cs # src/AngleSharp.Diffing/Core/HtmlDifferenceEngine.cs # src/AngleSharp.Diffing/Strategies/AttributeStrategies/OrderingStyleAttributeComparer.cs # src/AngleSharp.Diffing/Strategies/AttributeStrategies/StyleAttributeComparer.cs # src/Directory.Build.props
2 parents 7a0c5e1 + 1118b70 commit 5694c9b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+271
-169
lines changed

‎CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# 1.0.0
2+
3+
- Enabled using `diff:ignoreAttributes` and `diff:ignoreChildren` together on the same element.
4+
- Corrected list of attributes that is considered as boolean attributes. Removed `hidden`, added `inert`, `playsinline`, `shadowrootclonable`, `shadowrootdelegatesfocus`, and `shadowrootserializable`.
5+
- Upgrade to v1.x of AngleSharp.
6+
17
# 0.18.2
28

39
- Changed `CompareStrategy` such that it now can control the `IDiff` type that should be returned in case a difference is found in a comparison. This allows a comparer to embed additional context in the `IDiff` object. By [@SebastianStehle](https://github.com/SebastianStehle).

‎src/.editorconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,3 +225,6 @@ dotnet_naming_style.fields_begin_with__.required_prefix = _
225225
dotnet_naming_style.fields_begin_with__.required_suffix =
226226
dotnet_naming_style.fields_begin_with__.word_separator =
227227
dotnet_naming_style.fields_begin_with__.capitalization = camel_case
228+
229+
# MA0012: Do not raise reserved exception type
230+
dotnet_diagnostic.MA0012.severity = none

‎src/AngleSharp.Diffing.Tests/AngleSharp.DiffingTests.csproj

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFramework>net8.0</TargetFramework>
55
<IsPackable>false</IsPackable>
66
<AssemblyName>AngleSharp.Diffing.Tests</AssemblyName>
77
<RootNamespace>AngleSharp.Diffing</RootNamespace>
@@ -10,18 +10,18 @@
1010
</PropertyGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
14-
<PackageReference Include="GitHubActionsTestLogger" Version="2.0.1">
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
14+
<PackageReference Include="GitHubActionsTestLogger" Version="2.4.1">
1515
<PrivateAssets>all</PrivateAssets>
1616
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1717
</PackageReference>
18-
<PackageReference Include="Shouldly" Version="4.1.0" />
19-
<PackageReference Include="xunit" Version="2.4.2" />
20-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
18+
<PackageReference Include="Shouldly" Version="4.2.1" />
19+
<PackageReference Include="xunit" Version="2.9.2" />
20+
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
2121
<PrivateAssets>all</PrivateAssets>
2222
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2323
</PackageReference>
24-
<PackageReference Include="coverlet.collector" Version="3.2.0">
24+
<PackageReference Include="coverlet.collector" Version="6.0.2">
2525
<PrivateAssets>all</PrivateAssets>
2626
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2727
</PackageReference>

‎src/AngleSharp.Diffing.Tests/Core/AttributeComparisonTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void Test005()
6565
var test = ToAttributeComparisonSource(@"<br foo=""bar"">", "foo");
6666
var comparison = new AttributeComparison(control, test);
6767

68-
var (actualCtrlElm, actualTestElm) = comparison.GetAttributeElements();
68+
var (actualCtrlElm, actualTestElm) = comparison.AttributeElements;
6969

7070
actualCtrlElm.ShouldBe(control.ElementSource.Node);
7171
actualTestElm.ShouldBe(test.ElementSource.Node);
@@ -135,7 +135,7 @@ public void Test005()
135135
var test = ToAttributeComparisonSource(@"<br foo=""bar"">", "foo");
136136
var comparison = new AttributeComparison(control, test);
137137

138-
var (actualCtrlElm, actualTestElm) = comparison.GetAttributeElements();
138+
var (actualCtrlElm, actualTestElm) = comparison.AttributeElements;
139139

140140
actualCtrlElm.ShouldBe(control.ElementSource.Node);
141141
actualTestElm.ShouldBe(test.ElementSource.Node);

‎src/AngleSharp.Diffing.Tests/Core/DiffingEngineTestBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ namespace AngleSharp.Diffing.Core;
22

33
public abstract class DiffingEngineTestBase : DiffingTestBase
44
{
5-
public DiffingEngineTestBase(DiffingTestFixture fixture) : base(fixture)
5+
protected DiffingEngineTestBase(DiffingTestFixture fixture) : base(fixture)
66
{
77
}
88

@@ -24,7 +24,7 @@ protected static HtmlDiffer CreateHtmlDiffer(
2424
);
2525
}
2626

27-
private class MockDiffingStrategy : IDiffingStrategy
27+
private sealed class MockDiffingStrategy : IDiffingStrategy
2828
{
2929
private readonly Func<ComparisonSource, FilterDecision>? _nodeFilter;
3030
private readonly Func<AttributeComparisonSource, FilterDecision>? _attrFilter;

‎src/AngleSharp.Diffing.Tests/Core/HtmlDifferenceEngineTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ private static IEnumerable<Comparison> NoneNodeMatcher(IDiffContext ctx, SourceC
451451
private static Func<IDiffContext, SourceCollection, SourceCollection, IEnumerable<Comparison>> SpecificIndexNodeMatcher(int index)
452452
=> (ctx, controlNodes, testNodes) =>
453453
{
454-
return new List<Comparison> { new Comparison(controlNodes[index], testNodes[index]) };
454+
return new List<Comparison> { new(controlNodes[index], testNodes[index]) };
455455
};
456456

457457
private static IEnumerable<Comparison> OneToOneNodeListMatcher(
@@ -477,7 +477,7 @@ private static Func<IDiffContext, SourceMap, SourceMap, IEnumerable<AttributeCom
477477
{
478478
return (ctx, ctrlAttrs, testAttrs) => new List<AttributeComparison>
479479
{
480-
new AttributeComparison(ctrlAttrs[matchAttrName], testAttrs[matchAttrName] )
480+
new(ctrlAttrs[matchAttrName], testAttrs[matchAttrName] )
481481
};
482482
}
483483

@@ -510,14 +510,14 @@ private static Func<AttributeComparisonSource, FilterDecision> SpecificAttrFilte
510510
#endregion
511511

512512
#region CustomDiff
513-
public record CustomNodeDiff : NodeDiff
513+
public sealed record CustomNodeDiff : NodeDiff
514514
{
515515
public CustomNodeDiff(in Comparison comparison) : base(comparison)
516516
{
517517
}
518518
}
519519

520-
public record CustomAttrDiff : AttrDiff
520+
public sealed record CustomAttrDiff : AttrDiff
521521
{
522522
public CustomAttrDiff(in AttributeComparison comparison) : base(comparison, AttrDiffKind.Unspecified)
523523
{

‎src/AngleSharp.Diffing.Tests/DiffBuilderTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public void Test001()
2020
[Fact(DisplayName = "Builder throws if null is passed to control and test")]
2121
public void Test002()
2222
{
23-
Should.Throw<ArgumentNullException>(() => DiffBuilder.Compare(null!)).ParamName.ShouldBe(nameof(DiffBuilder.Control));
24-
Should.Throw<ArgumentNullException>(() => DiffBuilder.Compare("").WithTest(null!)).ParamName.ShouldBe(nameof(DiffBuilder.Test));
23+
Should.Throw<ArgumentNullException>(() => DiffBuilder.Compare(null!)).ParamName.ShouldBe("value");
24+
Should.Throw<ArgumentNullException>(() => DiffBuilder.Compare("").WithTest(null!)).ParamName.ShouldBe("value");
2525
}
2626

2727
[Fact(DisplayName = "Calling Build() with DefaultOptions() returns expected diffs")]

‎src/AngleSharp.Diffing.Tests/DiffingTestBase.cs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,18 @@ public abstract class DiffingTestBase : IClassFixture<DiffingTestFixture>
44
{
55
private readonly DiffingTestFixture _testFixture;
66

7+
8+
public static readonly TheoryData<CompareResult> SameAndSkipCompareResult = new()
9+
{
10+
CompareResult.Same,
11+
CompareResult.Skip,
12+
};
13+
714
protected IDiffContext DummyContext { get; } = new DiffContext(default(IElement), default(IElement));
815

916
protected INodeList EmptyNodeList => ToNodeList("");
1017

11-
public DiffingTestBase(DiffingTestFixture fixture)
18+
protected DiffingTestBase(DiffingTestFixture fixture)
1219
{
1320
_testFixture = fixture;
1421
}
@@ -68,10 +75,4 @@ protected SourceMap ToSourceMap(string html, ComparisonSourceType sourceType = C
6875
var source = ToComparisonSource(html, sourceType);
6976
return new SourceMap(source);
7077
}
71-
72-
public static TheoryData<CompareResult> SameAndSkipCompareResult = new TheoryData<CompareResult>
73-
{
74-
CompareResult.Same,
75-
CompareResult.Skip,
76-
};
7778
}

‎src/AngleSharp.Diffing.Tests/GlobalSuppressions.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
// This file is used by Code Analysis to maintain SuppressMessage
2+
// attributes that are applied to this project.
3+
// Project-level suppressions either have no target or are given
4+
// a specific target and scoped to a namespace, type, member, etc.
5+
6+
using System.Diagnostics.CodeAnalysis;
7+
8+
[assembly: SuppressMessage("Usage", "CA2201:Do not raise reserved exception types", Justification = "Not relevant in tests.")]
9+
[assembly: SuppressMessage("Design", "CA1034:Nested types should not be visible", Justification = "Not relevant in tests")]

‎src/AngleSharp.Diffing.Tests/Strategies/DiffingStrategyPipelineTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ public DiffingStrategyPipelineTest(DiffingTestFixture fixture) : base(fixture)
66
{
77
}
88

9-
private FilterDecision NegateDecision(FilterDecision decision) => decision switch
9+
private static FilterDecision NegateDecision(FilterDecision decision) => decision switch
1010
{
1111
FilterDecision.Keep => FilterDecision.Exclude,
1212
FilterDecision.Exclude => FilterDecision.Keep,

‎src/AngleSharp.Diffing.Tests/Strategies/ElementStrategies/IgnoreAttributesElementComparerTest.cs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,19 @@ public void Test002(string controlHtml)
3232
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.Unknown).ShouldBe(CompareResult.SkipAttributes);
3333
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.Unknown).ShouldBe(CompareResult.SkipAttributes);
3434
}
35+
36+
[Theory(DisplayName = "When a control element has both 'diff:ignoreChildren' and a 'diff:ignoreAttributes'")]
37+
[InlineData("<button diff:ignoreAttributes diff:ignoreChildren></button>", @"<button id=""buttonid"" class=""somecss"">Not Ignored</button>")]
38+
[InlineData("<button diff:ignoreAttributes diff:ignoreChildren></button>", @"<button id=""buttonid"" class=""somecss""><span>Not Ignored</span></button>")]
39+
public void Test003(string controlHtml, string testHtml)
40+
{
41+
var comparison = ToComparison(controlHtml, testHtml);
42+
43+
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.Same).ShouldBe(CompareResult.SkipAttributes);
44+
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.Unknown).ShouldBe(CompareResult.SkipAttributes);
45+
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.Skip).ShouldBe(CompareResult.Skip);
46+
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.SkipChildrenAndAttributes).ShouldBe(CompareResult.SkipChildrenAndAttributes);
47+
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.SkipChildren).ShouldBe(CompareResult.SkipChildrenAndAttributes);
48+
IgnoreAttributesElementComparer.Compare(comparison, CompareResult.SkipAttributes).ShouldBe(CompareResult.SkipAttributes);
49+
}
3550
}

‎src/AngleSharp.Diffing.Tests/Strategies/ElementStrategies/IgnoreChildrenElementComparerTest.cs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,19 @@ public void Test002(string controlHtml)
3232
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.Unknown).ShouldBe(CompareResult.SkipChildren);
3333
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.Unknown).ShouldBe(CompareResult.SkipChildren);
3434
}
35+
36+
[Theory(DisplayName = "When a control element has both 'diff:ignoreChildren' and a 'diff:ignoreAttributes'")]
37+
[InlineData("<button diff:ignoreAttributes diff:ignoreChildren></button>", @"<button id=""buttonid"" class=""somecss"">Not Ignored</button>")]
38+
[InlineData("<button diff:ignoreAttributes diff:ignoreChildren></button>", @"<button id=""buttonid"" class=""somecss""><span>Not Ignored</span></button>")]
39+
public void Test003(string controlHtml, string testHtml)
40+
{
41+
var comparison = ToComparison(controlHtml, testHtml);
42+
43+
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.Same).ShouldBe(CompareResult.SkipChildren);
44+
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.Unknown).ShouldBe(CompareResult.SkipChildren);
45+
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.Skip).ShouldBe(CompareResult.Skip);
46+
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.SkipChildrenAndAttributes).ShouldBe(CompareResult.SkipChildrenAndAttributes);
47+
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.SkipAttributes).ShouldBe(CompareResult.SkipChildrenAndAttributes);
48+
IgnoreChildrenElementComparer.Compare(comparison, CompareResult.SkipChildren).ShouldBe(CompareResult.SkipChildren);
49+
}
3550
}

‎src/AngleSharp.Diffing.Tests/Strategies/TextNodeStrategies/TextNodeTestBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public abstract class TextNodeTestBase : DiffingTestBase
1818

1919
public static readonly IEnumerable<object[]> WhitespaceCharStrings = AllWhitespaceCharacters.Select(c => new string[] { c.ToString(CultureInfo.InvariantCulture) }).ToArray();
2020

21-
public TextNodeTestBase(DiffingTestFixture fixture) : base(fixture)
21+
protected TextNodeTestBase(DiffingTestFixture fixture) : base(fixture)
2222
{
2323
}
2424
}

‎src/AngleSharp.Diffing.sln

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio Version 16
4-
VisualStudioVersion = 16.0.29230.61
3+
# Visual Studio Version 17
4+
VisualStudioVersion = 17.11.35312.102
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AngleSharp.Diffing", "AngleSharp.Diffing\AngleSharp.Diffing.csproj", "{2BFFA992-22C2-4A65-94D8-CA06E81D2364}"
77
EndProject
88
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AngleSharp.DiffingTests", "AngleSharp.Diffing.Tests\AngleSharp.DiffingTests.csproj", "{18203D98-66B4-4736-B79A-3B7D02EFA9E8}"
99
EndProject
1010
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{E8E3C8B4-92C3-4DB7-B920-D28651E24A57}"
1111
ProjectSection(SolutionItems) = preProject
12-
..\.editorconfig = ..\.editorconfig
12+
.editorconfig = .editorconfig
1313
..\tools\anglesharp.cake = ..\tools\anglesharp.cake
1414
..\build.cake = ..\build.cake
1515
..\build.ps1 = ..\build.ps1

‎src/AngleSharp.Diffing/AngleSharp.Diffing.csproj

Lines changed: 36 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,44 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<PropertyGroup>
4-
<TargetFramework>netstandard2.0</TargetFramework>
5-
<GenerateDocumentationFile>true</GenerateDocumentationFile>
6-
</PropertyGroup>
3+
<PropertyGroup>
4+
<TargetFramework>netstandard2.0</TargetFramework>
5+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
6+
</PropertyGroup>
77

8-
<PropertyGroup>
9-
<Description>Provides a complete diffing model of HTML.</Description>
10-
<Product>AngleSharp.Diffing</Product>
11-
<Authors>AngleSharp</Authors>
12-
<PackageId>AngleSharp.Diffing</PackageId>
13-
<PackageLicenseExpression>MIT</PackageLicenseExpression>
14-
<PackageProjectUrl>https://anglesharp.github.io</PackageProjectUrl>
15-
<PackageIcon>logo.png</PackageIcon>
16-
<PackageIconUrl>https://raw.github.com/AngleSharp/AngleSharp.Diffing/master/logo.png</PackageIconUrl>
17-
<PackageTags>html html5 css css3 dom library diffing anglesharp diff difference compare comparison testing</PackageTags>
18-
<Copyright>Egil Hansen</Copyright>
19-
<RepositoryUrl>https://github.com/AngleSharp/AngleSharp.Diffing</RepositoryUrl>
20-
<RepositoryType>git</RepositoryType>
21-
<PublishRepositoryUrl>true</PublishRepositoryUrl>
22-
<IncludeSymbols>true</IncludeSymbols>
23-
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
24-
</PropertyGroup>
8+
<PropertyGroup>
9+
<Description>Provides a complete diffing model of HTML.</Description>
10+
<Product>AngleSharp.Diffing</Product>
11+
<Authors>AngleSharp</Authors>
12+
<PackageId>AngleSharp.Diffing</PackageId>
13+
<PackageLicenseExpression>MIT</PackageLicenseExpression>
14+
<PackageProjectUrl>https://anglesharp.github.io</PackageProjectUrl>
15+
<PackageIcon>logo.png</PackageIcon>
16+
<PackageIconUrl>https://raw.github.com/AngleSharp/AngleSharp.Diffing/master/logo.png</PackageIconUrl>
17+
<PackageTags>html html5 css css3 dom library diffing anglesharp diff difference compare comparison testing</PackageTags>
18+
<Copyright>Egil Hansen</Copyright>
19+
<RepositoryUrl>https://github.com/AngleSharp/AngleSharp.Diffing</RepositoryUrl>
20+
<RepositoryType>git</RepositoryType>
21+
<PublishRepositoryUrl>true</PublishRepositoryUrl>
22+
<IncludeSymbols>true</IncludeSymbols>
23+
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
24+
<NoWarn>$(NoWarn);NU5104</NoWarn>
25+
</PropertyGroup>
2526

26-
<ItemGroup>
27-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
28-
</ItemGroup>
27+
<ItemGroup>
28+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
29+
</ItemGroup>
2930

30-
<ItemGroup>
31-
<PackageReference Include="TunnelVisionLabs.ReferenceAssemblyAnnotator" Version="1.0.0-alpha.160" PrivateAssets="all" />
32-
<PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[5.0.0]" />
33-
</ItemGroup>
31+
<ItemGroup>
32+
<PackageReference Include="Meziantou.Analyzer" Version="2.0.169">
33+
<PrivateAssets>all</PrivateAssets>
34+
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
35+
</PackageReference>
36+
<PackageReference Include="TunnelVisionLabs.ReferenceAssemblyAnnotator" Version="1.0.0-alpha.160" PrivateAssets="all" />
37+
<PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[5.0.0]" />
38+
</ItemGroup>
3439

35-
<ItemGroup>
36-
<None Include="..\..\logo.png" Pack="true" PackagePath="\" />
37-
<None Include="..\..\LICENSE" Pack="true" PackagePath="\" />
38-
</ItemGroup>
40+
<ItemGroup>
41+
<None Include="..\..\logo.png" Pack="true" PackagePath="\" />
42+
</ItemGroup>
3943

4044
</Project>

‎src/AngleSharp.Diffing/Core/AttributeComparison.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
1+
using System.Runtime.InteropServices;
2+
13
namespace AngleSharp.Diffing.Core;
24

35
/// <summary>
46
/// A match between two attributes that should be compared.
57
/// </summary>
68
/// <param name="Control">Gets the control attribute which the <see cref="Test"/> attribute is supposed to match.</param>
79
/// <param name="Test">Gets the test attribute which should be compared to the <see cref="Control"/> attribute.</param>
10+
[StructLayout(LayoutKind.Auto)]
811
public readonly record struct AttributeComparison(in AttributeComparisonSource Control, in AttributeComparisonSource Test)
912
{
1013
/// <summary>
1114
/// Returns the control and test elements which the control and test attributes belongs to.
1215
/// </summary>
13-
public (IElement ControlElement, IElement TestElement) GetAttributeElements()
16+
public readonly (IElement ControlElement, IElement TestElement) AttributeElements
1417
=> ((IElement)Control.ElementSource.Node, (IElement)Test.ElementSource.Node);
1518
}

‎src/AngleSharp.Diffing/Core/AttributeComparisonSource.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ namespace AngleSharp.Diffing.Core;
3030
/// </summary>
3131
/// <param name="attributeName">Name of the attribute.</param>
3232
/// <param name="elementSource">The source of the element the attribute belongs to.</param>
33+
[SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Attribute names should be safe to lowercase.")]
3334
public AttributeComparisonSource(string attributeName, in ComparisonSource elementSource)
3435
{
3536
if (string.IsNullOrEmpty(attributeName))

‎src/AngleSharp.Diffing/Core/CompareDecision.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public enum CompareDecision
99
/// <summary>
1010
/// Use when the compare result is unknown.
1111
/// </summary>
12-
Unknown = 0,
12+
None = 0,
1313
/// <summary>
1414
/// Use when the two compared nodes or attributes are the same.
1515
/// </summary>

0 commit comments

Comments
 (0)