Skip to content

Commit 229dd7f

Browse files
Revert "drop workaround over esbuild bug fixed upstream"
This reverts commit c678f84. trigger pulled too soon: - evanw/esbuild#619 was gone - but then come evanw/esbuild#1958
1 parent f33e3e0 commit 229dd7f

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

esbuild.config.cjs

+13-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,18 @@ const fs = require('fs')
22

33
const esbuild = require('esbuild')
44

5+
// XXX taken from https://github.com/evanw/esbuild/issues/619#issuecomment-751995294
6+
// XXX `plugins: [makeAllPackagesExternalPlugin]` were supposed to be superceeded by
7+
// XXX `external: ['./node_modules/*']` but...
8+
// XXX ... we're blocked by what seems to be https://github.com/evanw/esbuild/issues/1958
9+
const makeAllPackagesExternalPlugin = {
10+
name: 'make-all-packages-external',
11+
setup: (build) => {
12+
const filter = /^[^./]|^\.[^./]|^\.\.[^/]/ // Must not start with "/" or "./" or "../"
13+
build.onResolve({ filter }, (arguments_) => ({ external: true, path: arguments_.path }))
14+
}
15+
}
16+
517
const catcher = (error) => {
618
console.error(error)
719
// eslint-disable-next-line unicorn/no-process-exit
@@ -22,7 +34,7 @@ const builder = (entryPoints, outdir = 'dist', platform = targets.Node) =>
2234
sourcemap: true,
2335
sourcesContent: false,
2436
...(platform === targets.Node
25-
? { external: ['./node_modules/*'], target: 'node14' }
37+
? { plugins: [makeAllPackagesExternalPlugin], target: 'node14' }
2638
: {
2739
inject: ['src/ui/react-shim.ts'],
2840
jsxFactory: 'h',

0 commit comments

Comments
 (0)