Skip to content

Tenant Manager: is RegistryDeploymentInfoService needed? #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EricWittmann opened this issue Aug 30, 2021 · 3 comments
Closed

Tenant Manager: is RegistryDeploymentInfoService needed? #1797

EricWittmann opened this issue Aug 30, 2021 · 3 comments
Assignees
Labels
type/question Further information is requested

Comments

@EricWittmann
Copy link
Member

This service requires a property called registry.route.url that has no default value. Tenant Manager will not start up with out. The health check service seems to use this information.

However this seems to introduce a dependency from Tenant Manager -> Service Registry. I don't think we want that. Is this perhaps a leftover from an earlier architecture choice related to registry instance reaping?

@EricWittmann EricWittmann added the type/question Further information is requested label Aug 30, 2021
@famarting
Copy link
Contributor

the dependency tenant manager -> service registry exists because in some tenant manager API endpoints it returns the full url of the tenant, and for that we need the registry route url

however we may not be using that information and building the tenant url by hand in our control plane instead of taking what the tenant manager returns, so we could drop this dependency, wdyt?

@EricWittmann
Copy link
Member Author

I would really like to avoid a tenant manager -> service registry link if we can avoid it. However, if it's just configuration information then it could make sense. In this case it seems like it is. This may be even more useful when running Registry and Tenant Manager without a separate control plane. We should decide how we expect users to run this stuff upstream... do we imagine they will create their own control plane or use the tenant manager as the control plane? Can it perform that function by itself?

@famarting
Copy link
Contributor

actually, reviewing the code again, the registry.route.url property is used for the liveness check and for an API endpoint that is not even used in our rest client...

in short, we could perfectly remove the registry.route.url and drop the tenant manager -> service registry link with no issues

about running this stuff upstream you already have the answer, the multitenant UI you built, actually that UI have some logic to build the final tenant's url so, even today people would have to build their own control plane in order to have a more integrated solution that works like create registry -> return new tenant full url.

Also if it wasn't clear do we imagine they will create their own control plane or use the tenant manager as the control plane? Can it perform that function by itself? -> yes, no and no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants