Skip to content

Extract admin endpoints from the rest client to an admin client. #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlesarnal opened this issue Nov 18, 2021 · 5 comments · Fixed by #2240
Closed

Extract admin endpoints from the rest client to an admin client. #2026

carlesarnal opened this issue Nov 18, 2021 · 5 comments · Fixed by #2240
Labels
Beginner Friendly Solving this issue can help people who are starting with the project learn type/task

Comments

@carlesarnal
Copy link
Member

No description provided.

@carlesarnal carlesarnal added type/task Beginner Friendly Solving this issue can help people who are starting with the project learn Seeking Contribution labels Nov 18, 2021
@jhughes24816
Copy link
Contributor

Could someone please provide some details as to what this issue is about?

@famarting
Copy link
Contributor

sure, it just means to separate the methods here in two different interfaces, one for the /admin part of our API and another one for the rest

@famarting
Copy link
Contributor

also important to mention that we should always have in mind backwards compatibility, and therefore do this kind of changes in a way that don't break user's code. We should first deprecate the methods in the old interface while creating a new Admin interface, and later on (i.e. two releases after) remove the deprecated methods

@jhughes24816
Copy link
Contributor

Okay, thanks. Couple of follow up questions:

  1. Currently going through the v1/openapi.json and v2/openapi.json, in v2 I found /admin end points. Are there any end points in v1 that would be considered admin e.g. possibly /rules?
  2. With the interfaces split, would it be useful to split the RegistryClientImpl in a similar way?

@famarting
Copy link
Contributor

the v1 api is just kept for compatibility with old clients. the current interface RegistryClient and it's implementation only targets the latest version of our API, in this case v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner Friendly Solving this issue can help people who are starting with the project learn type/task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants