Skip to content

Duplicate update in JPA? #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alesj opened this issue Jan 19, 2020 · 4 comments
Closed

Duplicate update in JPA? #227

alesj opened this issue Jan 19, 2020 · 4 comments
Assignees
@alesj

Comments

@alesj
Copy link
Contributor

alesj commented Jan 19, 2020

@jsenko why do we do duplicate persist here?
First with nextVersion, then with null as version ... ?!

apicurio-registry/storage/jpa/src/main/java/io/apicurio/registry/storage/impl/jpa/JPARegistryStorage.java

Line 215 in e74d5fa

.persistUpdate(entityManager, artifactId, null)

@jsenko
Copy link
Member

jsenko commented Jan 20, 2020 •
edited
Loading

The first metadata entity represents metadata for the artifact version, the second metadata that is persisted is for artifact (i.e. all the versions).
We are creating both a new artifact and an initial version of it.

@alesj
Copy link
Contributor Author

alesj commented Jan 20, 2020

OK, I see ... this should be a lot more optimised ... less inserts/updates ... I'll see what can be done.

@EricWittmann
Copy link
Member

@alesj this was fixed in a recent PR, was it not?

@alesj
Copy link
Contributor Author

alesj commented Feb 1, 2020

@EricWittmann yes, this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alesj alesj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alesj @jsenko @EricWittmann