Incorrect artifact createdOn and modifiedOn date when using Kafka topic storage

[ajborley]

When using the Kafka topic storage, Apicurio sets the artifact createdOn and modifiedOn metadata fields using the current system timestamp when the record was read out of Kafka (see (1) and (2)). This means that when a server restarts it will return different metadata for the same backing data. It also means that a cluster of Apicurio servers will each return different metadata for the same artifact.

Alternatives would be to use the Kafka record timestamps (so the createdOn field would match the time that the record was originally produced), or store the timestamps as part of the metadata object.

(1)

apicurio-registry/app/src/main/java/io/apicurio/registry/storage/impl/AbstractMapRegistryStorage.java

Lines 209 to 211 in 54d82c2

	String currentTimeMillis = String.valueOf(System.currentTimeMillis());
	contents.put(MetaDataKeys.CREATED_ON, currentTimeMillis);
	contents.put(MetaDataKeys.MODIFIED_ON, currentTimeMillis);

(2)

apicurio-registry/storage/kafka/src/main/java/io/apicurio/registry/kafka/KafkaRegistryStorage.java

Lines 334 to 339 in a077f18

	cf.complete(createOrUpdateArtifact(
	artifactId,
	ArtifactType.values()[artifact.getArtifactType()],
	ContentHandle.create(content),
	Str.ActionType.CREATE == type,
	offset));

[ajborley]

This may be related to issue #653

[EricWittmann]

@carlesarnal and @alesj Any thoughts on this bug?

[EricWittmann]

Or does this only apply to the Kafka storage which will be deprecated/removed? If so then maybe it doesn't matter.

[carlesarnal]

Please @alesj, correct me if I'm wrong, but I think this only applies to the Kafka storage.

[alesj]

Yes, this is Kafka storage only.
Even if deprecated, it should still be fixed -- and @ajborley suggestion with the record timestamp looks OK.