Skip to content

Test that deploy to maven central succeeded (release workflow) #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EricWittmann opened this issue Jul 31, 2020 · 5 comments · Fixed by #779
Closed

Test that deploy to maven central succeeded (release workflow) #730

EricWittmann opened this issue Jul 31, 2020 · 5 comments · Fixed by #779

Comments

@EricWittmann
Copy link
Member

Add a step to the release workflow where we verify that the artifacts were actually deployed properly to maven central. At a minimum we should have a simple test/demo maven project that we can use to build and verify that the appropriate artifacts are available.

@jsenko
Copy link
Member

jsenko commented Aug 4, 2020

Can we build the examples repo after the release, so we don't have to use a separate test repo. We can add a profile to the examples that would make sure all artifacts are downloaded.

@EricWittmann
Copy link
Member Author

So I think what we can do here is twofold:

  1. A basic curl command that tries to download one or two of the artifacts using a direct URL to maven central
  2. We can create a basic standalone maven project (this can be just a pom.xml really) that pulls in one or more Apicurio Registry artifacts as dependencies - once the push is done we can clean out the local .m2/repository equivalent and then mvn package the test project

Note that for (1) the URL can be something like this (for example):

https://repo.maven.apache.org/maven2/io/apicurio/apicurio-registry-client/$RELEASE_VERSION/apicurio-registry-client-$RELEASE_VERSION.pom

If the push failed then this would result in a 404. Otherwise it will work.

@riprasad
Copy link
Member

riprasad commented Aug 5, 2020

Are we going to do both or just the curl command would be sufficient? @EricWittmann

@riprasad
Copy link
Member

riprasad commented Aug 5, 2020

Also, Instead of including the steps in the release workflow, I would suggest that we should have a third workflow verify-release.yaml where we could verify both the docker push and deploy to maven central. WDYT @EricWittmann @jsenko

@EricWittmann
Copy link
Member Author

I think we should do both the curl and the sample project. The curl goes first as a quick smoke test, and then building the sample project as a more thorough test.

I'm fine with a separate workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants