Fix false positive with as const (fixes #80)

Author: ArnaudBarre

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Fix false positive with `as const` (fixes [#80](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/80))
+
 ## 0.4.19
 
 Add name to configs for [ESLint Config Inspector](https://github.com/eslint/config-inspector)

src/only-export-components.test.ts

@@ -198,6 +198,11 @@ const valid = [
     name: "Local constant with component casing and non component function",
     code: "const SomeConstant = 42; export function someUtility() { return SomeConstant }",
   },
+  {
+    name: "Component and as const constant with allowConstantExport",
+    code: "export const MyComponent = () => {}; export const MENU_WIDTH = 232 as const;",
+    options: [{ allowConstantExport: true }],
+  },
 ];
 
 const invalid = [

src/only-export-components.ts

@@ -112,10 +112,7 @@ export const onlyExportComponents: TSESLint.RuleModule<
           if (
             allowConstantExport &&
             init &&
-            (init.type === "Literal" || // 1, "foo"
-              init.type === "UnaryExpression" || // -1
-              init.type === "TemplateLiteral" || // `Some ${template}`
-              init.type === "BinaryExpression") // 24 * 60
+            constantExportExpressions.has(skipTSWrapper(init).type)
           ) {
             return;
           }
@@ -223,11 +220,7 @@ export const onlyExportComponents: TSESLint.RuleModule<
             context.report({ messageId: "exportAll", node });
           } else if (node.type === "ExportDefaultDeclaration") {
             hasExports = true;
-            const declaration =
-              node.declaration.type === "TSAsExpression" ||
-              node.declaration.type === "TSSatisfiesExpression"
-                ? node.declaration.expression
-                : node.declaration;
+            const declaration = skipTSWrapper(node.declaration);
             if (
               declaration.type === "VariableDeclaration" ||
               declaration.type === "FunctionDeclaration" ||
@@ -301,7 +294,22 @@ export const onlyExportComponents: TSESLint.RuleModule<
   },
 };
 
+const skipTSWrapper = <T extends TSESTree.Node>(node: T) => {
+  if (node.type === "TSAsExpression" || node.type === "TSSatisfiesExpression") {
+    return node.expression;
+  }
+  return node;
+};
+
 type ToString<T> = T extends `${infer V}` ? V : never;
+const constantExportExpressions = new Set<
+  ToString<TSESTree.Expression["type"]>
+>([
+  "Literal", // 1, "foo"
+  "UnaryExpression", // -1
+  "TemplateLiteral", // `Some ${template}`
+  "BinaryExpression", // 24 * 60
+]);
 const notReactComponentExpression = new Set<
   ToString<TSESTree.Expression["type"]>
 >([