Skip to content

Commit 3a68151

Browse files
NimitS1NimitS1
committed
PR comment
1 parent b058432 commit 3a68151

12 files changed

+49
-97
lines changed

‎Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs

+2-4
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ public static void WriteTrace(
4646

4747
if (isRootTrace)
4848
{
49-
writer.WriteFieldName("start date");
50-
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateFormatString));
51-
writer.WriteFieldName("start time");
52-
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.HourTimeFormatString));
49+
writer.WriteFieldName("start datetime");
50+
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateTimeFormatString));
5351
}
5452
writer.WriteFieldName("duration in milliseconds");
5553
writer.WriteNumber64Value(trace.Duration.TotalMilliseconds);

‎Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace Microsoft.Azure.Cosmos.Tracing
1818
internal static partial class TraceWriter
1919
{
2020
internal static readonly string HourTimeFormatString = "HH:mm:ss:fff";
21-
internal static readonly string DateFormatString = "yyyy-MM-dd";
21+
internal static readonly string DateTimeFormatString = "yyyy-MM-ddTHH:mm:ss.fffZ";
2222

2323
private static class TraceTextWriter
2424
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@
6161
<Json><![CDATA[{
6262
"Summary": {},
6363
"name": "ExecuteAsync",
64-
"start date": "0001-01-01",
65-
"start time": "00:00:00:000",
64+
"start datetime": "0001-01-01T00:00:00Z",
6665
"duration in milliseconds": 0,
6766
"data": {
6867
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml

+11-22
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@
6060
<Json><![CDATA[{
6161
"Summary": {},
6262
"name": "CreateItemAsync",
63-
"start date": "0001-01-01",
64-
"start time": "00:00:00:000",
63+
"start datetime": "0001-01-01T00:00:00Z",
6564
"duration in milliseconds": 0,
6665
"data": {
6766
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -219,8 +218,7 @@
219218
<Json><![CDATA[{
220219
"Summary": {},
221220
"name": "CreateItemAsync",
222-
"start date": "0001-01-01",
223-
"start time": "00:00:00:000",
221+
"start datetime": "0001-01-01T00:00:00Z",
224222
"duration in milliseconds": 0,
225223
"data": {
226224
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -378,8 +376,7 @@
378376
<Json><![CDATA[{
379377
"Summary": {},
380378
"name": "CreateItemAsync",
381-
"start date": "0001-01-01",
382-
"start time": "00:00:00:000",
379+
"start datetime": "0001-01-01T00:00:00Z",
383380
"duration in milliseconds": 0,
384381
"data": {
385382
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -537,8 +534,7 @@
537534
<Json><![CDATA[{
538535
"Summary": {},
539536
"name": "CreateItemAsync",
540-
"start date": "0001-01-01",
541-
"start time": "00:00:00:000",
537+
"start datetime": "0001-01-01T00:00:00Z",
542538
"duration in milliseconds": 0,
543539
"data": {
544540
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -696,8 +692,7 @@
696692
<Json><![CDATA[{
697693
"Summary": {},
698694
"name": "CreateItemAsync",
699-
"start date": "0001-01-01",
700-
"start time": "00:00:00:000",
695+
"start datetime": "0001-01-01T00:00:00Z",
701696
"duration in milliseconds": 0,
702697
"data": {
703698
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -855,8 +850,7 @@
855850
<Json><![CDATA[{
856851
"Summary": {},
857852
"name": "CreateItemAsync",
858-
"start date": "0001-01-01",
859-
"start time": "00:00:00:000",
853+
"start datetime": "0001-01-01T00:00:00Z",
860854
"duration in milliseconds": 0,
861855
"data": {
862856
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1014,8 +1008,7 @@
10141008
<Json><![CDATA[{
10151009
"Summary": {},
10161010
"name": "CreateItemAsync",
1017-
"start date": "0001-01-01",
1018-
"start time": "00:00:00:000",
1011+
"start datetime": "0001-01-01T00:00:00Z",
10191012
"duration in milliseconds": 0,
10201013
"data": {
10211014
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1173,8 +1166,7 @@
11731166
<Json><![CDATA[{
11741167
"Summary": {},
11751168
"name": "CreateItemAsync",
1176-
"start date": "0001-01-01",
1177-
"start time": "00:00:00:000",
1169+
"start datetime": "0001-01-01T00:00:00Z",
11781170
"duration in milliseconds": 0,
11791171
"data": {
11801172
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1332,8 +1324,7 @@
13321324
<Json><![CDATA[{
13331325
"Summary": {},
13341326
"name": "CreateItemAsync",
1335-
"start date": "0001-01-01",
1336-
"start time": "00:00:00:000",
1327+
"start datetime": "0001-01-01T00:00:00Z",
13371328
"duration in milliseconds": 0,
13381329
"data": {
13391330
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1491,8 +1482,7 @@
14911482
<Json><![CDATA[{
14921483
"Summary": {},
14931484
"name": "CreateItemAsync",
1494-
"start date": "0001-01-01",
1495-
"start time": "00:00:00:000",
1485+
"start datetime": "0001-01-01T00:00:00Z",
14961486
"duration in milliseconds": 0,
14971487
"data": {
14981488
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1806,8 +1796,7 @@
18061796
<Json><![CDATA[{
18071797
"Summary": {},
18081798
"name": "CreateItemAsync",
1809-
"start date": "0001-01-01",
1810-
"start time": "00:00:00:000",
1799+
"start datetime": "0001-01-01T00:00:00Z",
18111800
"duration in milliseconds": 0,
18121801
"data": {
18131802
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml

+5-10
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@
238238
<Json><![CDATA[{
239239
"Summary": {},
240240
"name": "Trace Forest",
241-
"start date": "0001-01-01",
242-
"start time": "00:00:00:000",
241+
"start datetime": "0001-01-01T00:00:00Z",
243242
"duration in milliseconds": 0,
244243
"children": [
245244
{
@@ -1125,8 +1124,7 @@
11251124
<Json><![CDATA[{
11261125
"Summary": {},
11271126
"name": "Trace Forest",
1128-
"start date": "0001-01-01",
1129-
"start time": "00:00:00:000",
1127+
"start datetime": "0001-01-01T00:00:00Z",
11301128
"duration in milliseconds": 0,
11311129
"children": [
11321130
{
@@ -1740,8 +1738,7 @@
17401738
<Json><![CDATA[{
17411739
"Summary": {},
17421740
"name": "Trace Forest",
1743-
"start date": "0001-01-01",
1744-
"start time": "00:00:00:000",
1741+
"start datetime": "0001-01-01T00:00:00Z",
17451742
"duration in milliseconds": 0,
17461743
"children": [
17471744
{
@@ -2343,8 +2340,7 @@
23432340
<Json><![CDATA[{
23442341
"Summary": {},
23452342
"name": "Trace Forest",
2346-
"start date": "0001-01-01",
2347-
"start time": "00:00:00:000",
2343+
"start datetime": "0001-01-01T00:00:00Z",
23482344
"duration in milliseconds": 0,
23492345
"children": [
23502346
{
@@ -2892,8 +2888,7 @@
28922888
<Json><![CDATA[{
28932889
"Summary": {},
28942890
"name": "Trace Forest",
2895-
"start date": "0001-01-01",
2896-
"start time": "00:00:00:000",
2891+
"start datetime": "0001-01-01T00:00:00Z",
28972892
"duration in milliseconds": 0,
28982893
"children": [
28992894
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml

+2-4
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@
4444
<Json><![CDATA[{
4545
"Summary": {},
4646
"name": "CreateDatabaseAsync",
47-
"start date": "0001-01-01",
48-
"start time": "00:00:00:000",
47+
"start datetime": "0001-01-01T00:00:00Z",
4948
"duration in milliseconds": 0,
5049
"data": {
5150
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -155,8 +154,7 @@
155154
<Json><![CDATA[{
156155
"Summary": {},
157156
"name": "CreateDatabaseAsync",
158-
"start date": "0001-01-01",
159-
"start time": "00:00:00:000",
157+
"start datetime": "0001-01-01T00:00:00Z",
160158
"duration in milliseconds": 0,
161159
"data": {
162160
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml

+6-12
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@
6868
<Json><![CDATA[{
6969
"Summary": {},
7070
"name": "CreateItemAsync",
71-
"start date": "0001-01-01",
72-
"start time": "00:00:00:000",
71+
"start datetime": "0001-01-01T00:00:00Z",
7372
"duration in milliseconds": 0,
7473
"data": {
7574
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -255,8 +254,7 @@
255254
<Json><![CDATA[{
256255
"Summary": {},
257256
"name": "CreateItemAsync",
258-
"start date": "0001-01-01",
259-
"start time": "00:00:00:000",
257+
"start datetime": "0001-01-01T00:00:00Z",
260258
"duration in milliseconds": 0,
261259
"data": {
262260
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -516,8 +514,7 @@
516514
<Json><![CDATA[{
517515
"Summary": {},
518516
"name": "CreateItemAsync",
519-
"start date": "0001-01-01",
520-
"start time": "00:00:00:000",
517+
"start datetime": "0001-01-01T00:00:00Z",
521518
"duration in milliseconds": 0,
522519
"data": {
523520
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -753,8 +750,7 @@
753750
<Json><![CDATA[{
754751
"Summary": {},
755752
"name": "CreateItemAsync",
756-
"start date": "0001-01-01",
757-
"start time": "00:00:00:000",
753+
"start datetime": "0001-01-01T00:00:00Z",
758754
"duration in milliseconds": 0,
759755
"data": {
760756
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1033,8 +1029,7 @@
10331029
<Json><![CDATA[{
10341030
"Summary": {},
10351031
"name": "CreateItemAsync",
1036-
"start date": "0001-01-01",
1037-
"start time": "00:00:00:000",
1032+
"start datetime": "0001-01-01T00:00:00Z",
10381033
"duration in milliseconds": 0,
10391034
"data": {
10401035
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1272,8 +1267,7 @@
12721267
<Json><![CDATA[{
12731268
"Summary": {},
12741269
"name": "CreateItemAsync",
1275-
"start date": "0001-01-01",
1276-
"start time": "00:00:00:000",
1270+
"start datetime": "0001-01-01T00:00:00Z",
12771271
"duration in milliseconds": 0,
12781272
"data": {
12791273
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml

+7-14
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,7 @@
163163
<Json><![CDATA[{
164164
"Summary": {},
165165
"name": "Trace Forest",
166-
"start date": "0001-01-01",
167-
"start time": "00:00:00:000",
166+
"start datetime": "0001-01-01T00:00:00Z",
168167
"duration in milliseconds": 0,
169168
"children": [
170169
{
@@ -754,8 +753,7 @@
754753
<Json><![CDATA[{
755754
"Summary": {},
756755
"name": "Trace Forest",
757-
"start date": "0001-01-01",
758-
"start time": "00:00:00:000",
756+
"start datetime": "0001-01-01T00:00:00Z",
759757
"duration in milliseconds": 0,
760758
"children": [
761759
{
@@ -1358,8 +1356,7 @@
13581356
<Json><![CDATA[{
13591357
"Summary": {},
13601358
"name": "Trace Forest",
1361-
"start date": "0001-01-01",
1362-
"start time": "00:00:00:000",
1359+
"start datetime": "0001-01-01T00:00:00Z",
13631360
"duration in milliseconds": 0,
13641361
"children": [
13651362
{
@@ -1950,8 +1947,7 @@
19501947
<Json><![CDATA[{
19511948
"Summary": {},
19521949
"name": "Trace Forest",
1953-
"start date": "0001-01-01",
1954-
"start time": "00:00:00:000",
1950+
"start datetime": "0001-01-01T00:00:00Z",
19551951
"duration in milliseconds": 0,
19561952
"children": [
19571953
{
@@ -2581,8 +2577,7 @@
25812577
<Json><![CDATA[{
25822578
"Summary": {},
25832579
"name": "Trace Forest",
2584-
"start date": "0001-01-01",
2585-
"start time": "00:00:00:000",
2580+
"start datetime": "0001-01-01T00:00:00Z",
25862581
"duration in milliseconds": 0,
25872582
"children": [
25882583
{
@@ -3232,8 +3227,7 @@
32323227
<Json><![CDATA[{
32333228
"Summary": {},
32343229
"name": "Trace Forest",
3235-
"start date": "0001-01-01",
3236-
"start time": "00:00:00:000",
3230+
"start datetime": "0001-01-01T00:00:00Z",
32373231
"duration in milliseconds": 0,
32383232
"children": [
32393233
{
@@ -3833,8 +3827,7 @@
38333827
<Json><![CDATA[{
38343828
"Summary": {},
38353829
"name": "Trace Forest",
3836-
"start date": "0001-01-01",
3837-
"start time": "00:00:00:000",
3830+
"start datetime": "0001-01-01T00:00:00Z",
38383831
"duration in milliseconds": 0,
38393832
"children": [
38403833
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml

+4-8
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,7 @@
139139
<Json><![CDATA[{
140140
"Summary": {},
141141
"name": "Trace Forest",
142-
"start date": "0001-01-01",
143-
"start time": "00:00:00:000",
142+
"start datetime": "0001-01-01T00:00:00Z",
144143
"duration in milliseconds": 0,
145144
"children": [
146145
{
@@ -692,8 +691,7 @@
692691
<Json><![CDATA[{
693692
"Summary": {},
694693
"name": "Trace Forest",
695-
"start date": "0001-01-01",
696-
"start time": "00:00:00:000",
694+
"start datetime": "0001-01-01T00:00:00Z",
697695
"duration in milliseconds": 0,
698696
"children": [
699697
{
@@ -1258,8 +1256,7 @@
12581256
<Json><![CDATA[{
12591257
"Summary": {},
12601258
"name": "Trace Forest",
1261-
"start date": "0001-01-01",
1262-
"start time": "00:00:00:000",
1259+
"start datetime": "0001-01-01T00:00:00Z",
12631260
"duration in milliseconds": 0,
12641261
"children": [
12651262
{
@@ -1812,8 +1809,7 @@
18121809
<Json><![CDATA[{
18131810
"Summary": {},
18141811
"name": "Trace Forest",
1815-
"start date": "0001-01-01",
1816-
"start time": "00:00:00:000",
1812+
"start datetime": "0001-01-01T00:00:00Z",
18171813
"duration in milliseconds": 0,
18181814
"children": [
18191815
{

0 commit comments

Comments
 (0)