Skip to content

Commit 94c83f5

Browse files
NimitS1ealsur
NimitS1
and
ealsur
authored
Diagnostics: Adds startDate in Summary (#3707)
* Adding start date * Updated trace files * PR comment * Committing missing tests --------- Co-authored-by: Matias Quaranta <[email protected]>
1 parent b257f8e commit 94c83f5

15 files changed

+66
-65
lines changed

‎Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ public static void WriteTrace(
4646

4747
if (isRootTrace)
4848
{
49-
writer.WriteFieldName("start time");
50-
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.HourTimeFormatString));
49+
writer.WriteFieldName("start datetime");
50+
writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateTimeFormatString));
5151
}
5252
writer.WriteFieldName("duration in milliseconds");
5353
writer.WriteNumber64Value(trace.Duration.TotalMilliseconds);

‎Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ namespace Microsoft.Azure.Cosmos.Tracing
1818
internal static partial class TraceWriter
1919
{
2020
internal static readonly string HourTimeFormatString = "HH:mm:ss:fff";
21+
internal static readonly string DateTimeFormatString = "yyyy-MM-ddTHH:mm:ss.fffZ";
2122

2223
private static class TraceTextWriter
2324
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<Json><![CDATA[{
6262
"Summary": {},
6363
"name": "ExecuteAsync",
64-
"start time": "00:00:00:000",
64+
"start datetime": "0001-01-01T00:00:00Z",
6565
"duration in milliseconds": 0,
6666
"data": {
6767
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml

+11-11
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
<Json><![CDATA[{
6161
"Summary": {},
6262
"name": "CreateItemAsync",
63-
"start time": "00:00:00:000",
63+
"start datetime": "0001-01-01T00:00:00Z",
6464
"duration in milliseconds": 0,
6565
"data": {
6666
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -218,7 +218,7 @@
218218
<Json><![CDATA[{
219219
"Summary": {},
220220
"name": "CreateItemAsync",
221-
"start time": "00:00:00:000",
221+
"start datetime": "0001-01-01T00:00:00Z",
222222
"duration in milliseconds": 0,
223223
"data": {
224224
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -376,7 +376,7 @@
376376
<Json><![CDATA[{
377377
"Summary": {},
378378
"name": "CreateItemAsync",
379-
"start time": "00:00:00:000",
379+
"start datetime": "0001-01-01T00:00:00Z",
380380
"duration in milliseconds": 0,
381381
"data": {
382382
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -534,7 +534,7 @@
534534
<Json><![CDATA[{
535535
"Summary": {},
536536
"name": "CreateItemAsync",
537-
"start time": "00:00:00:000",
537+
"start datetime": "0001-01-01T00:00:00Z",
538538
"duration in milliseconds": 0,
539539
"data": {
540540
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -692,7 +692,7 @@
692692
<Json><![CDATA[{
693693
"Summary": {},
694694
"name": "CreateItemAsync",
695-
"start time": "00:00:00:000",
695+
"start datetime": "0001-01-01T00:00:00Z",
696696
"duration in milliseconds": 0,
697697
"data": {
698698
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -850,7 +850,7 @@
850850
<Json><![CDATA[{
851851
"Summary": {},
852852
"name": "CreateItemAsync",
853-
"start time": "00:00:00:000",
853+
"start datetime": "0001-01-01T00:00:00Z",
854854
"duration in milliseconds": 0,
855855
"data": {
856856
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1008,7 +1008,7 @@
10081008
<Json><![CDATA[{
10091009
"Summary": {},
10101010
"name": "CreateItemAsync",
1011-
"start time": "00:00:00:000",
1011+
"start datetime": "0001-01-01T00:00:00Z",
10121012
"duration in milliseconds": 0,
10131013
"data": {
10141014
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1166,7 +1166,7 @@
11661166
<Json><![CDATA[{
11671167
"Summary": {},
11681168
"name": "CreateItemAsync",
1169-
"start time": "00:00:00:000",
1169+
"start datetime": "0001-01-01T00:00:00Z",
11701170
"duration in milliseconds": 0,
11711171
"data": {
11721172
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1324,7 +1324,7 @@
13241324
<Json><![CDATA[{
13251325
"Summary": {},
13261326
"name": "CreateItemAsync",
1327-
"start time": "00:00:00:000",
1327+
"start datetime": "0001-01-01T00:00:00Z",
13281328
"duration in milliseconds": 0,
13291329
"data": {
13301330
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1482,7 +1482,7 @@
14821482
<Json><![CDATA[{
14831483
"Summary": {},
14841484
"name": "CreateItemAsync",
1485-
"start time": "00:00:00:000",
1485+
"start datetime": "0001-01-01T00:00:00Z",
14861486
"duration in milliseconds": 0,
14871487
"data": {
14881488
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1796,7 +1796,7 @@
17961796
<Json><![CDATA[{
17971797
"Summary": {},
17981798
"name": "CreateItemAsync",
1799-
"start time": "00:00:00:000",
1799+
"start datetime": "0001-01-01T00:00:00Z",
18001800
"duration in milliseconds": 0,
18011801
"data": {
18021802
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml

+5-5
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@
238238
<Json><![CDATA[{
239239
"Summary": {},
240240
"name": "Trace Forest",
241-
"start time": "00:00:00:000",
241+
"start datetime": "0001-01-01T00:00:00Z",
242242
"duration in milliseconds": 0,
243243
"children": [
244244
{
@@ -1124,7 +1124,7 @@
11241124
<Json><![CDATA[{
11251125
"Summary": {},
11261126
"name": "Trace Forest",
1127-
"start time": "00:00:00:000",
1127+
"start datetime": "0001-01-01T00:00:00Z",
11281128
"duration in milliseconds": 0,
11291129
"children": [
11301130
{
@@ -1738,7 +1738,7 @@
17381738
<Json><![CDATA[{
17391739
"Summary": {},
17401740
"name": "Trace Forest",
1741-
"start time": "00:00:00:000",
1741+
"start datetime": "0001-01-01T00:00:00Z",
17421742
"duration in milliseconds": 0,
17431743
"children": [
17441744
{
@@ -2340,7 +2340,7 @@
23402340
<Json><![CDATA[{
23412341
"Summary": {},
23422342
"name": "Trace Forest",
2343-
"start time": "00:00:00:000",
2343+
"start datetime": "0001-01-01T00:00:00Z",
23442344
"duration in milliseconds": 0,
23452345
"children": [
23462346
{
@@ -2888,7 +2888,7 @@
28882888
<Json><![CDATA[{
28892889
"Summary": {},
28902890
"name": "Trace Forest",
2891-
"start time": "00:00:00:000",
2891+
"start datetime": "0001-01-01T00:00:00Z",
28922892
"duration in milliseconds": 0,
28932893
"children": [
28942894
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<Json><![CDATA[{
4545
"Summary": {},
4646
"name": "CreateDatabaseAsync",
47-
"start time": "00:00:00:000",
47+
"start datetime": "0001-01-01T00:00:00Z",
4848
"duration in milliseconds": 0,
4949
"data": {
5050
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -154,7 +154,7 @@
154154
<Json><![CDATA[{
155155
"Summary": {},
156156
"name": "CreateDatabaseAsync",
157-
"start time": "00:00:00:000",
157+
"start datetime": "0001-01-01T00:00:00Z",
158158
"duration in milliseconds": 0,
159159
"data": {
160160
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml

+6-6
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<Json><![CDATA[{
6969
"Summary": {},
7070
"name": "CreateItemAsync",
71-
"start time": "00:00:00:000",
71+
"start datetime": "0001-01-01T00:00:00Z",
7272
"duration in milliseconds": 0,
7373
"data": {
7474
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -254,7 +254,7 @@
254254
<Json><![CDATA[{
255255
"Summary": {},
256256
"name": "CreateItemAsync",
257-
"start time": "00:00:00:000",
257+
"start datetime": "0001-01-01T00:00:00Z",
258258
"duration in milliseconds": 0,
259259
"data": {
260260
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -514,7 +514,7 @@
514514
<Json><![CDATA[{
515515
"Summary": {},
516516
"name": "CreateItemAsync",
517-
"start time": "00:00:00:000",
517+
"start datetime": "0001-01-01T00:00:00Z",
518518
"duration in milliseconds": 0,
519519
"data": {
520520
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -750,7 +750,7 @@
750750
<Json><![CDATA[{
751751
"Summary": {},
752752
"name": "CreateItemAsync",
753-
"start time": "00:00:00:000",
753+
"start datetime": "0001-01-01T00:00:00Z",
754754
"duration in milliseconds": 0,
755755
"data": {
756756
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1029,7 +1029,7 @@
10291029
<Json><![CDATA[{
10301030
"Summary": {},
10311031
"name": "CreateItemAsync",
1032-
"start time": "00:00:00:000",
1032+
"start datetime": "0001-01-01T00:00:00Z",
10331033
"duration in milliseconds": 0,
10341034
"data": {
10351035
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1267,7 +1267,7 @@
12671267
<Json><![CDATA[{
12681268
"Summary": {},
12691269
"name": "CreateItemAsync",
1270-
"start time": "00:00:00:000",
1270+
"start datetime": "0001-01-01T00:00:00Z",
12711271
"duration in milliseconds": 0,
12721272
"data": {
12731273
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml

+7-7
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
<Json><![CDATA[{
164164
"Summary": {},
165165
"name": "Trace Forest",
166-
"start time": "00:00:00:000",
166+
"start datetime": "0001-01-01T00:00:00Z",
167167
"duration in milliseconds": 0,
168168
"children": [
169169
{
@@ -753,7 +753,7 @@
753753
<Json><![CDATA[{
754754
"Summary": {},
755755
"name": "Trace Forest",
756-
"start time": "00:00:00:000",
756+
"start datetime": "0001-01-01T00:00:00Z",
757757
"duration in milliseconds": 0,
758758
"children": [
759759
{
@@ -1356,7 +1356,7 @@
13561356
<Json><![CDATA[{
13571357
"Summary": {},
13581358
"name": "Trace Forest",
1359-
"start time": "00:00:00:000",
1359+
"start datetime": "0001-01-01T00:00:00Z",
13601360
"duration in milliseconds": 0,
13611361
"children": [
13621362
{
@@ -1947,7 +1947,7 @@
19471947
<Json><![CDATA[{
19481948
"Summary": {},
19491949
"name": "Trace Forest",
1950-
"start time": "00:00:00:000",
1950+
"start datetime": "0001-01-01T00:00:00Z",
19511951
"duration in milliseconds": 0,
19521952
"children": [
19531953
{
@@ -2577,7 +2577,7 @@
25772577
<Json><![CDATA[{
25782578
"Summary": {},
25792579
"name": "Trace Forest",
2580-
"start time": "00:00:00:000",
2580+
"start datetime": "0001-01-01T00:00:00Z",
25812581
"duration in milliseconds": 0,
25822582
"children": [
25832583
{
@@ -3227,7 +3227,7 @@
32273227
<Json><![CDATA[{
32283228
"Summary": {},
32293229
"name": "Trace Forest",
3230-
"start time": "00:00:00:000",
3230+
"start datetime": "0001-01-01T00:00:00Z",
32313231
"duration in milliseconds": 0,
32323232
"children": [
32333233
{
@@ -3827,7 +3827,7 @@
38273827
<Json><![CDATA[{
38283828
"Summary": {},
38293829
"name": "Trace Forest",
3830-
"start time": "00:00:00:000",
3830+
"start datetime": "0001-01-01T00:00:00Z",
38313831
"duration in milliseconds": 0,
38323832
"children": [
38333833
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
<Json><![CDATA[{
140140
"Summary": {},
141141
"name": "Trace Forest",
142-
"start time": "00:00:00:000",
142+
"start datetime": "0001-01-01T00:00:00Z",
143143
"duration in milliseconds": 0,
144144
"children": [
145145
{
@@ -691,7 +691,7 @@
691691
<Json><![CDATA[{
692692
"Summary": {},
693693
"name": "Trace Forest",
694-
"start time": "00:00:00:000",
694+
"start datetime": "0001-01-01T00:00:00Z",
695695
"duration in milliseconds": 0,
696696
"children": [
697697
{
@@ -1256,7 +1256,7 @@
12561256
<Json><![CDATA[{
12571257
"Summary": {},
12581258
"name": "Trace Forest",
1259-
"start time": "00:00:00:000",
1259+
"start datetime": "0001-01-01T00:00:00Z",
12601260
"duration in milliseconds": 0,
12611261
"children": [
12621262
{
@@ -1809,7 +1809,7 @@
18091809
<Json><![CDATA[{
18101810
"Summary": {},
18111811
"name": "Trace Forest",
1812-
"start time": "00:00:00:000",
1812+
"start datetime": "0001-01-01T00:00:00Z",
18131813
"duration in milliseconds": 0,
18141814
"children": [
18151815
{

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadManyAsync.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
<Json><![CDATA[{
139139
"Summary": {},
140140
"name": "ReadManyItemsStreamAsync",
141-
"start time": "00:00:00:000",
141+
"start datetime": "0001-01-01T00:00:00Z",
142142
"duration in milliseconds": 0,
143143
"data": {
144144
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -696,7 +696,7 @@
696696
<Json><![CDATA[{
697697
"Summary": {},
698698
"name": "ReadManyItemsAsync",
699-
"start time": "00:00:00:000",
699+
"start datetime": "0001-01-01T00:00:00Z",
700700
"duration in milliseconds": 0,
701701
"data": {
702702
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

‎Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.StreamPointOperationsAsync.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<Json><![CDATA[{
4242
"Summary": {},
4343
"name": "CreateItemStreamAsync",
44-
"start time": "00:00:00:000",
44+
"start datetime": "0001-01-01T00:00:00Z",
4545
"duration in milliseconds": 0,
4646
"data": {
4747
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -130,7 +130,7 @@
130130
<Json><![CDATA[{
131131
"Summary": {},
132132
"name": "ReadItemStreamAsync",
133-
"start time": "00:00:00:000",
133+
"start datetime": "0001-01-01T00:00:00Z",
134134
"duration in milliseconds": 0,
135135
"data": {
136136
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -227,7 +227,7 @@
227227
<Json><![CDATA[{
228228
"Summary": {},
229229
"name": "ReplaceItemStreamAsync",
230-
"start time": "00:00:00:000",
230+
"start datetime": "0001-01-01T00:00:00Z",
231231
"duration in milliseconds": 0,
232232
"data": {
233233
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -319,7 +319,7 @@
319319
<Json><![CDATA[{
320320
"Summary": {},
321321
"name": "DeleteItemStreamAsync",
322-
"start time": "00:00:00:000",
322+
"start datetime": "0001-01-01T00:00:00Z",
323323
"duration in milliseconds": 0,
324324
"data": {
325325
"Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

0 commit comments

Comments
 (0)