Skip to content

OpenTelemetry net.peer.name attribute is out of date #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JamesNK opened this issue Feb 5, 2024 · 1 comment · Fixed by #4316
Closed

OpenTelemetry net.peer.name attribute is out of date #4309

JamesNK opened this issue Feb 5, 2024 · 1 comment · Fixed by #4316
Assignees
Labels
customer-reported Issue created by a customer needs-investigation

Comments

@JamesNK
Copy link

JamesNK commented Feb 5, 2024

The net.peer.name attribute here is out of date.

address.server is the modern name. See open-telemetry/opentelemetry-specification#3199

Should also add peer.service which is a general name: https://github.com/open-telemetry/semantic-conventions/blob/482cb01c4598429c65dd0b123b30259f41b360cb/docs/general/attributes.md#general-remote-service-attributes

@sourabh1007
Copy link
Contributor

Discussed this with @lmolkova and @jcocchi. Agreed to make this change as HTTP semantic conventions are stable now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issue created by a customer needs-investigation
Projects
None yet
3 participants