Styling fixes for Get-AzureSqlDatabaseRestorePoints

Author: caln-microsoft

src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj

@@ -156,7 +156,9 @@
     <None Include="ScenarioTests\DatabaseActivationTests.ps1">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
-    <None Include="ScenarioTests\DatabaseBackupTests.ps1" />
+    <None Include="ScenarioTests\DatabaseBackupTests.ps1">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Include="ScenarioTests\RecommendedElasticPoolTests.ps1">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DatabaseBackupTests.ps1

@@ -36,15 +36,11 @@ function Test-ListDatabaseRestorePoints
 		$standarddb = New-AzureSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName `
 			-Edition Standard -RequestedServiceObjectiveName S0
 
-		# Get restore points from data warehouse database.
+		# Get restore points from data warehouse database. There should be none.
 		$restorePoints =  Get-AzureSqlDatabaseRestorePoints -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $dwdb.DatabaseName
-		$restorePoint = $restorePoints[0]
-		Assert-AreEqual $restorePoint.RestorePointType Discrete
-		Assert-NotNull $restorePoint.RestorePointCreationDate 
-		Assert-Null $restorePoint.EarliestRestoreDate 
-		Assert-AreEqual $restorePoint.SizeBytes 0
+		Assert-True $restorePoints.IsEmpty
 
-		# Get restore points from standard database.
+		# Get restore points from standard database.There should be 1.
 		$restorePoints = Resume-AzureSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $standarddb.DatabaseName
 		$restorePoint = $restorePoints[0]
 		Assert-AreEqual $restorePoint.RestorePointType Continuous
@@ -83,12 +79,7 @@ function Test-ListDatabaseRestorePointsPiped
 			-Edition Standard -RequestedServiceObjectiveName S0
 
 		# Get restore points from data warehouse database.
-		$restorePoints =  $dwdb | Get-AzureSqlDatabaseRestorePoints
-		$restorePoint = $restorePoints[0]
-		Assert-AreEqual $restorePoint.RestorePointType Discrete
-		Assert-NotNull $restorePoint.RestorePointCreationDate 
-		Assert-Null $restorePoint.EarliestRestoreDate 
-		Assert-AreEqual $restorePoint.SizeBytes 0
+		Assert-True $restorePoints.IsEmpty
 
 		# Get restore points from standard database.
 		$restorePoints = $standarddb | Resume-AzureSqlDatabase

src/ResourceManager/Sql/Commands.Sql.Test/UnitTests/AzureSqlDatabaseBackupAttributeTests.cs

@@ -26,7 +26,7 @@ public class AzureSqlDatabaseBackupAttributeTests
     {
         [Fact]
         [Trait(Category.Sql, Category.CheckIn)]
-        public void SuspendAzureSqlDatabaseAttributes()
+        public void GetAzureSqlDatabaseRestorePointsAttributes()
         {
             Type type = typeof(GetAzureSqlDatabaseRestorePoints);
             UnitTestHelper.CheckCmdletModifiesData(type, supportsShouldProcess: false);

src/ResourceManager/Sql/Commands.Sql/Database Backup/Cmdlet/AzureSqlDatabaseRestorePointCmdletBase.cs

@@ -35,6 +35,16 @@ public abstract class AzureSqlDatabaseRestorePointCmdletBase
         [ValidateNotNullOrEmpty]
         public string ServerName { get; set; }
 
+        /// <summary>
+        /// Gets or sets the name of the database to use.
+        /// </summary>
+        [Parameter(Mandatory = true,
+            ValueFromPipelineByPropertyName = true,
+            Position = 2,
+            HelpMessage = "The name of the Azure SQL Database to retrieve restore points from.")]
+        [ValidateNotNullOrEmpty]
+        public string DatabaseName { get; set; }
+
         /// <summary>
         /// Initializes the adapter
         /// </summary>

src/ResourceManager/Sql/Commands.Sql/Database Backup/Cmdlet/GetAzureSqlDatabaseRestorePoints.cs

@@ -24,25 +24,13 @@ namespace Microsoft.Azure.Commands.Sql.Backup.Cmdlet
         ConfirmImpact = ConfirmImpact.None)]
     public class GetAzureSqlDatabaseRestorePoints : AzureSqlDatabaseRestorePointCmdletBase
     {
-        /// <summary>
-        /// Gets or sets the name of the database to use.
-        /// </summary>
-        [Parameter(Mandatory = true,
-            ValueFromPipelineByPropertyName = true,
-            Position = 2,
-            HelpMessage = "The name of the Azure SQL Database to retrieve restore points from.")]
-        [ValidateNotNullOrEmpty]
-        public string DatabaseName { get; set; }
-
         /// <summary>
         /// Get the entities from the service
         /// </summary>
         /// <returns>The list of entities</returns>
         protected override IEnumerable<AzureSqlDatabaseRestorePointModel> GetEntity()
         {
-            IEnumerable<AzureSqlDatabaseRestorePointModel> results;
-            results = ModelAdapter.ListRestorePoints(this.ResourceGroupName, this.ServerName, this.DatabaseName);
-            return results;
+            return ModelAdapter.ListRestorePoints(this.ResourceGroupName, this.ServerName, this.DatabaseName);
         }
 
         /// <summary>

src/ResourceManager/Sql/Commands.Sql/Database Backup/Model/AzureSqlDatabaseRestorePointModel.cs

@@ -58,7 +58,7 @@ public class AzureSqlDatabaseRestorePointModel
         public DateTime? EarliestRestoreDate { get; set; }
 
         /// <summary>
-        /// Backup size in blob storage of the restore point. 
+        /// Size of the backup in blob storage.
         /// For discrete restore point, the value is the database snap size; for continuous restore point, the value is the 
         /// total backup storage usage of the database.
         /// </summary>

src/ResourceManager/Sql/Commands.Sql/Database Backup/Services/AzureSqlDatabaseBackupAdapter.cs

@@ -32,7 +32,7 @@
 namespace Microsoft.Azure.Commands.Sql.Backup.Services
 {
     /// <summary>
-    /// Adapter for database activation operations
+    /// Adapter for database backup operations
     /// </summary>
     public class AzureSqlDatabaseBackupAdapter
     {

src/ResourceManager/Sql/Commands.Sql/Database Backup/Services/AzureSqlDatabaseBackupCommunicator.cs

@@ -26,7 +26,7 @@
 namespace Microsoft.Azure.Commands.Sql.Backup.Services
 {
     /// <summary>
-    /// This class is responsible for all the REST communication with the database activation REST endpoints.
+    /// This class is responsible for all the REST communication with the database backup REST endpoints.
     /// </summary>
     public class AzureSqlDatabaseBackupCommunicator
     {
@@ -46,10 +46,10 @@ public class AzureSqlDatabaseBackupCommunicator
         public AzureProfile Profile { get; set; }
 
         /// <summary>
-        /// Creates a communicator for Azure Sql Databases
+        /// Creates a communicator for Azure Sql Database backup REST endpoints.
         /// </summary>
-        /// <param name="profile"></param>
-        /// <param name="subscription"></param>
+        /// <param name="profile">Azure profile</param>
+        /// <param name="subscription">Associated subscription</param>
         public AzureSqlDatabaseBackupCommunicator(AzureProfile profile, AzureSubscription subscription)
         {
             Profile = profile;
@@ -61,8 +61,12 @@ public AzureSqlDatabaseBackupCommunicator(AzureProfile profile, AzureSubscriptio
         }
 
         /// <summary>
-        /// Gets all the restore points for a given Azure Sql Database.
+        /// Lists the restore points for a given Sql Azure Database.
         /// </summary>
+        /// <param name="resourceGroup">The name of the resource group</param>
+        /// <param name="serverName">The name of the Azure SQL Server</param>
+        /// <param name="databaseName">The name of the Azure SQL database</param>
+        /// <returns>List of restore points</returns>
         public IList<Management.Sql.Models.RestorePoint> ListRestorePoints(string resourceGroupName, string serverName, string databaseName, string clientRequestId)
         {
             return GetCurrentSqlClient(clientRequestId).Backup.ListRestorePoints(resourceGroupName, serverName, databaseName).RestorePoints;