Update Policy CRUD cmdlets (#24361)

* Update to autorest 4.x
Update to Azure Policy 2023-04-01
Move to non-versioned interface types
Complete full test suite for existing cmdlets
Few bug fixes
Add completer for Location parameter
Fix record/playback, remove -LiveOnly tags
Make test names repeatable to work with record/playback
Implement resource group functions that became inaccessible
Fix test failures due to default parameter injection

* Clean up some transforms in README
Remove unsupported (for now) parameters
Streamline common test code
Move common test code to utils.ps1
Add serialization of test variables to env.json

* Remove extra parameters from Get-AzPolicyAssignment
Rerecord the tests

Author: mentat9

src/Resources/Policy.Autorest/README.md

@@ -330,8 +330,8 @@ directive:
 # For some reason these can't be hidden by hiding them in
 # the custom folder so we have to do it here.
   - where:
-      verb: New
-      subject: PolicyAssignment
+      verb: New|Update
+      subject: PolicyAssignment|PolicyExemption
       parameter-name: PolicyDefinitionId|ResourceSelector|Override
     hide: true
   - where:
@@ -341,18 +341,22 @@ directive:
     hide: true
   - where:
       verb: New|Update
-      subject: PolicyExemption
-      parameter-name: ResourceSelector
+      subject: PolicyDefinition|PolicySetDefinition
+      parameter-name: Version|PropertiesVersions
+    hide: true
+  - where:
+      verb: Get
+      parameter-name: Top
     hide: true
 
-  # Hide cmdlets that are customized or not supported at all
+  # Remove or hide cmdlets that are customized or not supported at all
   - where:
       verb: Get|Remove|Update
     hide: true
   - where:
       verb: New|Remove|Update
       subject: PolicyDefinitionVersion|PolicySetDefinitionVersion
-    hide: true
+    remove: true
 
 metadata:
   scriptsToProcess:

src/Resources/Policy.Autorest/custom/Get-AzPolicyAssignment.ps1

@@ -75,21 +75,6 @@ param(
     # Get all policy assignments that target the given policy definition [fully qualified] ID.
     ${IncludeDescendent},
 
-    # This switch is implemented and working, but confusing, since -Top is a misleading name. Due to backend implementation
-    # of $top, this parameter should actually be called -Pagesize. Addressing this issue is beyond the scope of the initial
-    # port to autorest: we will address this in the future and hide the parameter for now to avoid future backcompat complexity.
-    [Parameter(ParameterSetName='Default', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Scope', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='PolicyDefinitionId', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='IncludeDescendent', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Top', Mandatory, ValueFromPipelineByPropertyName)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Query')]
-    [System.Int32]
-    # Maximum number of records to return.
-    # When -Top is not provided, this cmdlet will return 500 or fewer records.
-    [Parameter(DontShow)]
-    ${Top},
-
     [Parameter()]
     [System.Management.Automation.SwitchParameter]
     # Causes cmdlet to return artifacts using legacy format placing policy-specific properties in a property bag object.
@@ -106,45 +91,6 @@ param(
     # If $filter=policyDefinitionId eq '{value}' is provided, the returned list includes all policy assignments of the policy definition whose id is {value}.
     ${Filter},
 
-    [Parameter(DontShow)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
-    [System.String]
-    # The name of the resource group that contains policy assignments.
-    ${ResourceGroupName},
-
-    [Parameter(DontShow)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
-    [System.String[]]
-    # The ID of the target subscription.
-    ${SubscriptionId},
-
-    [Parameter(DontShow)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
-    [System.String]
-    # The parent resource path.
-    # Use empty string if there is none.
-    ${ParentResourcePath},
-
-    [Parameter(DontShow)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
-    [System.String]
-    # The name of the resource.
-    ${ResourceName},
-
-    [Parameter(DontShow)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
-    [System.String]
-    # The namespace of the resource provider.
-    # For example, the namespace of a virtual machine is Microsoft.Compute (from Microsoft.Compute/virtualMachines)
-    ${ResourceProviderNamespace},
-
-    [Parameter(DontShow)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
-    [System.String]
-    # The resource type name.
-    # For example the type name of a web app is 'sites' (from Microsoft.Web/sites).
-    ${ResourceType},
-
     [Parameter(DontShow)]
     [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Path')]
     [Microsoft.Azure.PowerShell.Cmdlets.Policy.Models.IPolicyIdentity]
@@ -229,10 +175,6 @@ process {
 
     $calledParameters = $PSBoundParameters
 
-    # SubscriptionId is autorest-generated and mandatory so gets populated with default value.
-    # This customized cmdlet doesn't allow/use it, so we must remove it, otherwise the parameter set is broken.
-    $null = $calledParameters.Remove('SubscriptionId')
-
     if ($Name) {
         $calledParameterSet = 'Get'
         $calledParameters.NameInternal = $Name

src/Resources/Policy.Autorest/custom/Get-AzPolicyDefinition.ps1

@@ -88,23 +88,6 @@ param(
     # Causes cmdlet to return only static policy definitions.
     ${Static},
 
-    # This switch is implemented and working, but confusing, since -Top is a misleading name. Due to backend implementation
-    # of $top, this parameter should actually be called -Pagesize. Addressing this issue is beyond the scope of the initial
-    # port to autorest: we will address this in the future and hide the parameter for now to avoid future backcompat complexity.
-    [Parameter(ParameterSetName='Name', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='SubscriptionId', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='ManagementGroupName', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='BuiltIn', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Custom', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Static', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Top', Mandatory, ValueFromPipelineByPropertyName)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Query')]
-    [System.Int32]
-    # Maximum number of records to return.
-    # When -Top is not provided, this cmdlet will return 500 or fewer records.
-    [Parameter(DontShow)]
-    ${Top},
-
     [Parameter()]
     [System.Management.Automation.SwitchParameter]
     # Causes cmdlet to return artifacts using legacy format placing policy-specific properties in a property bag object.

src/Resources/Policy.Autorest/custom/Get-AzPolicySetDefinition.ps1

@@ -80,21 +80,6 @@ param(
     # Causes cmdlet to return only custom policy definitions.
     ${Custom},
 
-    # This switch is implemented and working, but confusing, since -Top is a misleading name. Due to backend implementation
-    # of $top, this parameter should actually be called -Pagesize. Addressing this is beyond the scope of the initial port
-    # to autorest: we will address this in the future and hide the parameter for now to avoid future backcompat complexity.
-    [Parameter(ParameterSetName='Name', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='SubscriptionId', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='BuiltIn', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Custom', ValueFromPipelineByPropertyName)]
-    [Parameter(ParameterSetName='Top', Mandatory, ValueFromPipelineByPropertyName)]
-    [Microsoft.Azure.PowerShell.Cmdlets.Policy.Category('Query')]
-    [System.Int32]
-    # Maximum number of records to return.
-    # When -Top is not provided, this cmdlet will return 500 or fewer records.
-    [Parameter(DontShow)]
-    ${Top},
-
     [Parameter()]
     [System.Management.Automation.SwitchParameter]
     # Causes cmdlet to return artifacts using legacy format placing policy-specific properties in a property bag object.

src/Resources/Policy.Autorest/docs/Get-AzPolicyAssignment.md

@@ -45,11 +45,6 @@ Get-AzPolicyAssignment -PolicyDefinitionId <String> [-Scope <String>] [-Backward
 Get-AzPolicyAssignment -Scope <String> [-BackwardCompatible] [-DefaultProfile <PSObject>] [<CommonParameters>]
 ```
 
-### Top
-```
-Get-AzPolicyAssignment [-BackwardCompatible] [-DefaultProfile <PSObject>] [<CommonParameters>]
-```
-
 ## DESCRIPTION
 The **Get-AzPolicyAssignment** cmdlet gets all policy assignments or particular assignments.
 Identify a policy assignment to get by name and scope or by ID.

src/Resources/Policy.Autorest/docs/Get-AzPolicyDefinition.md

@@ -53,11 +53,6 @@ Get-AzPolicyDefinition -SubscriptionId <String> [-Name <String>] [-BackwardCompa
  [-DefaultProfile <PSObject>] [<CommonParameters>]
 ```
 
-### Top
-```
-Get-AzPolicyDefinition [-BackwardCompatible] [-DefaultProfile <PSObject>] [<CommonParameters>]
-```
-
 ## DESCRIPTION
 The **Get-AzPolicySetDefinition** cmdlet gets a collection of policy set definitions or a specific policy set definition identified by name or ID.
 

src/Resources/Policy.Autorest/docs/Get-AzPolicySetDefinition.md

@@ -47,11 +47,6 @@ Get-AzPolicySetDefinition -SubscriptionId <String> [-Name <String>] [-BackwardCo
  [-DefaultProfile <PSObject>] [<CommonParameters>]
 ```
 
-### Top
-```
-Get-AzPolicySetDefinition [-BackwardCompatible] [-DefaultProfile <PSObject>] [<CommonParameters>]
-```
-
 ## DESCRIPTION
 The **Get-AzPolicySetDefinition** cmdlet gets a collection of policy set definitions or a specific policy set definition identified by name or ID.