Skip to content

Commit 1c59158

Browse files
committed
Merge pull request #703 from yoavrubin/dev
Unskipping SQL audit tests
2 parents c8ed539 + f206d33 commit 1c59158

File tree

3 files changed

+434
-291
lines changed

3 files changed

+434
-291
lines changed

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DataMaskingTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,49 +21,49 @@ public class DataMaskingTests : SqlTestsBase
2121
{
2222

2323
[Fact]
24-
[Trait(Category.RunType, Category.LiveOnly)]
24+
[Trait(Category.Sql, Category.CheckIn)]
2525
public void TestDatabaseDataMaskingPolicyEnablementToggling()
2626
{
2727
RunPowerShellTest("Test-DatabaseDataMaskingPolicyEnablementToggling");
2828
}
2929

3030
[Fact]
31-
[Trait(Category.RunType, Category.LiveOnly)]
31+
[Trait(Category.Sql, Category.CheckIn)]
3232
public void TestDatabaseDataMaskingPrivilegedLoginsChanges()
3333
{
3434
RunPowerShellTest("Test-DatabaseDataMaskingPrivilegedLoginsChanges");
3535
}
3636

3737
[Fact]
38-
[Trait(Category.RunType, Category.LiveOnly)]
38+
[Trait(Category.Sql, Category.CheckIn)]
3939
public void TestDatabaseDataMaskingBasicRuleLifecycle()
4040
{
4141
RunPowerShellTest("Test-DatabaseDataMaskingBasicRuleLifecycle");
4242
}
4343

4444
[Fact]
45-
[Trait(Category.RunType, Category.LiveOnly)]
45+
[Trait(Category.Sql, Category.CheckIn)]
4646
public void TestDatabaseDataMaskingNumberRuleLifecycle()
4747
{
4848
RunPowerShellTest("Test-DatabaseDataMaskingNumberRuleLifecycle");
4949
}
5050

5151
[Fact]
52-
[Trait(Category.RunType, Category.LiveOnly)]
52+
[Trait(Category.Sql, Category.CheckIn)]
5353
public void TestDatabaseDataMaskingTextRuleLifecycle()
5454
{
5555
RunPowerShellTest("Test-DatabaseDataMaskingTextRuleLifecycle");
5656
}
5757

5858
[Fact]
59-
[Trait(Category.RunType, Category.LiveOnly)]
59+
[Trait(Category.Sql, Category.CheckIn)]
6060
public void TestDatabaseDataMaskingRuleCreationFailures()
6161
{
6262
RunPowerShellTest("Test-DatabaseDataMaskingRuleCreationFailures");
6363
}
6464

6565
[Fact]
66-
[Trait(Category.RunType, Category.LiveOnly)]
66+
[Trait(Category.Sql, Category.CheckIn)]
6767
public void TestDatabaseDataMaskingRuleCreationWithoutPolicy()
6868
{
6969
RunPowerShellTest("Test-DatabaseDataMaskingRuleCreationWithoutPolicy");

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/SecurityTests.cs

Lines changed: 52 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -43,197 +43,183 @@ protected override void SetupManagementClients()
4343
}
4444

4545

46-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
47-
[Trait(Category.AcceptanceType, Category.CheckIn)]
46+
[Fact]
47+
[Trait(Category.Sql, Category.CheckIn)]
4848
public void TestDatabaseUpdatePolicyWithStorage()
4949
{
5050
RunPowerShellTest("Test-DatabaseUpdatePolicyWithStorage");
5151
}
5252

53-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
54-
[Trait(Category.AcceptanceType, Category.CheckIn)]
53+
[Fact]
54+
[Trait(Category.Sql, Category.CheckIn)]
5555
public void TestDatabaseUpdatePolicyWithStorageV2()
5656
{
5757
RunPowerShellTest("Test-DatabaseUpdatePolicyWithStorageV2");
5858
}
5959

60-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
61-
[Trait(Category.RunType, Category.LiveOnly)]
60+
[Fact]
61+
[Trait(Category.Sql, Category.CheckIn)]
6262
public void TestServerUpdatePolicyWithStorage()
6363
{
6464
RunPowerShellTest("Test-ServerUpdatePolicyWithStorage");
6565
}
6666

67-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
67+
[Fact]
68+
[Trait(Category.Sql, Category.CheckIn)]
6869
public void TestDatabaseUpdatePolicyWithEventTypes()
6970
{
7071
RunPowerShellTest("Test-DatabaseUpdatePolicyWithEventTypes");
7172
}
7273

73-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
74-
[Trait(Category.RunType, Category.LiveOnly)]
74+
[Fact]
75+
[Trait(Category.Sql, Category.CheckIn)]
7576
public void TestServerUpdatePolicyWithEventTypes()
7677
{
7778
RunPowerShellTest("Test-ServerUpdatePolicyWithEventTypes");
7879
}
7980

80-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
81-
[Trait(Category.RunType, Category.LiveOnly)]
82-
[Trait(Category.AcceptanceType, Category.CheckIn)]
81+
[Fact]
82+
[Trait(Category.Sql, Category.CheckIn)]
8383
public void TestDisableDatabaseAuditing()
8484
{
8585
RunPowerShellTest("Test-DisableDatabaseAuditing");
8686
}
8787

88-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
89-
[Trait(Category.RunType, Category.LiveOnly)]
90-
[Trait(Category.AcceptanceType, Category.CheckIn)]
88+
[Fact]
89+
[Trait(Category.Sql, Category.CheckIn)]
9190
public void TestDisableServerAuditing()
9291
{
9392
RunPowerShellTest("Test-DisableServerAuditing");
9493
}
9594

96-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
97-
[Trait(Category.RunType, Category.LiveOnly)]
98-
[Trait(Category.AcceptanceType, Category.CheckIn)]
95+
[Fact]
96+
[Trait(Category.Sql, Category.CheckIn)]
9997
public void TestDatabaseDisableEnableKeepProperties()
10098
{
10199
RunPowerShellTest("Test-DatabaseDisableEnableKeepProperties");
102100
}
103101

104-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
105-
[Trait(Category.RunType, Category.LiveOnly)]
106-
[Trait(Category.AcceptanceType, Category.CheckIn)]
102+
[Fact]
103+
[Trait(Category.Sql, Category.CheckIn)]
107104
public void TestServerDisableEnableKeepProperties()
108105
{
109106
RunPowerShellTest("Test-ServerDisableEnableKeepProperties");
110107
}
111108

112-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
113-
[Trait(Category.RunType, Category.LiveOnly)]
114-
[Trait(Category.AcceptanceType, Category.CheckIn)]
109+
[Fact]
110+
[Trait(Category.Sql, Category.CheckIn)]
115111
public void TestUseServerDefault()
116112
{
117113
RunPowerShellTest("Test-UseServerDefault");
118114
}
119115

120-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
121-
[Trait(Category.AcceptanceType, Category.CheckIn)]
116+
[Fact]
117+
[Trait(Category.Sql, Category.CheckIn)]
122118
public void TestFailedDatabaseUpdatePolicyWithNoStorage()
123119
{
124120
RunPowerShellTest("Test-FailedDatabaseUpdatePolicyWithNoStorage");
125121
}
126122

127-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
128-
[Trait(Category.RunType, Category.LiveOnly)]
129-
[Trait(Category.AcceptanceType, Category.CheckIn)]
123+
[Fact]
124+
[Trait(Category.Sql, Category.CheckIn)]
130125
public void TestFailedServerUpdatePolicyWithNoStorage()
131126
{
132127
RunPowerShellTest("Test-FailedServerUpdatePolicyWithNoStorage");
133128
}
134129

135-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
136-
[Trait(Category.RunType, Category.LiveOnly)]
137-
[Trait(Category.AcceptanceType, Category.CheckIn)]
130+
[Fact]
131+
[Trait(Category.Sql, Category.CheckIn)]
138132
public void TestFailedUseServerDefault()
139133
{
140134
RunPowerShellTest("Test-FailedUseServerDefault");
141135
}
142136

143-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
144-
[Trait(Category.RunType, Category.LiveOnly)]
145-
[Trait(Category.AcceptanceType, Category.CheckIn)]
137+
[Fact]
138+
[Trait(Category.Sql, Category.CheckIn)]
146139
public void TestDatabaseUpdatePolicyWithEventTypeShortcuts()
147140
{
148141
RunPowerShellTest("Test-DatabaseUpdatePolicyWithEventTypeShortcuts");
149142
}
150143

151-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
152-
[Trait(Category.RunType, Category.LiveOnly)]
153-
[Trait(Category.AcceptanceType, Category.CheckIn)]
144+
[Fact]
145+
[Trait(Category.Sql, Category.CheckIn)]
154146
public void TestServerUpdatePolicyWithEventTypeShortcuts()
155147
{
156148
RunPowerShellTest("Test-ServerUpdatePolicyWithEventTypeShortcuts");
157149
}
158150

159-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
160-
[Trait(Category.RunType, Category.LiveOnly)]
161-
[Trait(Category.AcceptanceType, Category.CheckIn)]
151+
[Fact]
152+
[Trait(Category.Sql, Category.CheckIn)]
162153
public void TestDatabaseUpdatePolicyKeepPreviousStorage()
163154
{
164155
RunPowerShellTest("Test-DatabaseUpdatePolicyKeepPreviousStorage");
165156
}
166157

167-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
168-
[Trait(Category.RunType, Category.LiveOnly)]
169-
[Trait(Category.AcceptanceType, Category.CheckIn)]
158+
[Fact]
159+
[Trait(Category.Sql, Category.CheckIn)]
170160
public void TestServerUpdatePolicyKeepPreviousStorage()
171161
{
172162
RunPowerShellTest("Test-ServerUpdatePolicyKeepPreviousStorage");
173163
}
174164

175-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
176-
[Trait(Category.RunType, Category.LiveOnly)]
177-
[Trait(Category.AcceptanceType, Category.CheckIn)]
165+
[Fact]
166+
[Trait(Category.Sql, Category.CheckIn)]
178167
public void TestFailWithBadDatabaseIndentity()
179168
{
180169
RunPowerShellTest("Test-FailWithBadDatabaseIndentity");
181170
}
182171

183-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
184-
[Trait(Category.RunType, Category.LiveOnly)]
185-
[Trait(Category.AcceptanceType, Category.CheckIn)]
172+
[Fact]
173+
[Trait(Category.Sql, Category.CheckIn)]
186174
public void TestFailWithBadServerIndentity()
187175
{
188176
RunPowerShellTest("Test-FailWithBadServerIndentity");
189177
}
190178

191-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
192-
[Trait(Category.RunType, Category.LiveOnly)]
193-
[Trait(Category.AcceptanceType, Category.CheckIn)]
179+
[Fact]
180+
[Trait(Category.Sql, Category.CheckIn)]
194181
public void TestDatabaseStorageKeyRotation()
195182
{
196183
RunPowerShellTest("Test-DatabaseStorageKeyRotation");
197184
}
198185

199-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
200-
[Trait(Category.RunType, Category.LiveOnly)]
201-
[Trait(Category.AcceptanceType, Category.CheckIn)]
186+
[Fact]
187+
[Trait(Category.Sql, Category.CheckIn)]
202188
public void TestServerStorageKeyRotation()
203189
{
204190
RunPowerShellTest("Test-ServerStorageKeyRotation");
205191
}
206192

207-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
208-
[Trait(Category.RunType, Category.LiveOnly)]
193+
[Fact]
194+
[Trait(Category.Sql, Category.CheckIn)]
209195
public void TestServerUpdatePolicyWithRetention()
210196
{
211197
RunPowerShellTest("Test-ServerUpdatePolicyWithRetention");
212198
}
213199

214-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
215-
[Trait(Category.RunType, Category.LiveOnly)]
200+
[Fact]
201+
[Trait(Category.Sql, Category.CheckIn)]
216202
public void TestDatabaseUpdatePolicyWithRetention()
217203
{
218204
RunPowerShellTest("Test-DatabaseUpdatePolicyWithRetention");
219205
}
220206

221-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
222-
[Trait(Category.RunType, Category.LiveOnly)]
207+
[Fact]
208+
[Trait(Category.Sql, Category.CheckIn)]
223209
public void TestServerRetentionKeepProperties()
224210
{
225211
RunPowerShellTest("Test-ServerRetentionKeepProperties");
226212
}
227213

228-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
229-
[Trait(Category.RunType, Category.LiveOnly)]
214+
[Fact]
215+
[Trait(Category.Sql, Category.CheckIn)]
230216
public void TestDatabaseRetentionKeepProperties()
231217
{
232218
RunPowerShellTest("Test-DatabaseRetentionKeepProperties");
233219
}
234220

235-
[Fact(Skip = "Skip for the version header upgrade on Storage library.")]
236-
[Trait(Category.RunType, Category.LiveOnly)]
221+
[Fact]
222+
[Trait(Category.Sql, Category.CheckIn)]
237223
public void TestDatabaseUpdatePolicyWithSameNameStorageOnDifferentRegion()
238224
{
239225
RunPowerShellTest("Test-DatabaseUpdatePolicyWithSameNameStorageOnDifferentRegion");

0 commit comments

Comments
 (0)