[Az.Accounts] Use mutex to prevent cross process file I/O #12281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
isra-fel
commented
Jun 29, 2020
| @@ -87,18 +92,17 @@ public StreamWriter CreateWriter() | |||
|
|
|||
| protected virtual void InitializeStream() | |||
| { | |||
| lock (_initializationLock) | |||
| _initializationLock.WaitOne(); | |||
There was a problem hiding this comment.
I believe we should use Mutex here, because TryGetStreamLock() may open files for write exclusively, see https://github.com/Azure/azure-powershell-common/blob/master/src/Authentication.Abstractions/DiskDataStore.cs#L324
isra-fel
changed the title
erich-wang
previously approved these changes
Jun 29, 2020
| } | ||
| _initializationLock.ReleaseMutex(); |
There was a problem hiding this comment.
how about put _initializationLock.ReleaseMutex() in finally block?
| } | ||
| fileLock.ReleaseMutex(); |
There was a problem hiding this comment.
suggest to put into finally block
erich-wang
approved these changes
Jun 29, 2020
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
litchiyangMSFT
pushed a commit
to litchiyangMSFT/azure-powershell
that referenced
this pull request
Aug 4, 2020
* use mutex to prevent cross process writing to token cache file * prevent cross-process write to profile file * change log * Use "Local" mutex; put ReleaseMutex() in finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #9448 for more info.
I also found another lock that needs to be replaced with Mutex: https://github.com/Azure/azure-powershell/blob/master/src/Accounts/Authentication.ResourceManager/ProtectedFileProvider.cs#L90
The other locks are safe.
I tested using Peter's sample code and it worked.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added