add default impl for AsyncTokenCred (#31585)

* add default impl for AsyncTokenCred

* update

* update

* update

* update

* update

* update

* update

* update changelog

* update

Author: xiangyan99

eng/tox/install_depend_packages.py

@@ -34,7 +34,7 @@
 MINIMUM_VERSION_GENERIC_OVERRIDES = {
     "azure-common": "1.1.10",
     "msrest": "0.6.10",
-    "typing-extensions": "3.6.5",
+    "typing-extensions": "4.6.0",
     "opentelemetry-api": "1.3.0",
     "opentelemetry-sdk": "1.3.0",
     "azure-core": "1.11.0",

sdk/cognitivelanguage/azure-ai-language-conversations/pyrightconfig.json

@@ -0,0 +1,10 @@
+{
+  "reportUnnecessaryCast": "warning",
+  "reportUnnecessaryTypeIgnoreComment": "warning",
+  "reportTypeCommentUsage": true,
+  "pythonVersion": "3.10",
+  "reportMissingImports": false,
+  "exclude": [
+    "**/samples/async/sample_authentication_async.py"
+  ]
+}

sdk/containerregistry/azure-containerregistry/azure/containerregistry/aio/_async_anonymous_exchange_client.py

@@ -3,7 +3,8 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 # ------------------------------------
-from typing import Optional, Union
+from types import TracebackType
+from typing import Optional, Union, Type
 
 from azure.core.credentials import AccessToken
 from azure.core.credentials_async import AsyncTokenCredential
@@ -27,7 +28,12 @@ async def close(self) -> None:
     async def __aenter__(self):
         pass
 
-    async def __aexit__(self, exc_type, exc_value, traceback) -> None:
+    async def __aexit__(
+        self,
+        exc_type: Optional[Type[BaseException]] = None,
+        exc_value: Optional[BaseException] = None,
+        traceback: Optional[TracebackType] = None,
+    ) -> None:
         pass
 
 

sdk/core/azure-core/CHANGELOG.md

@@ -1,15 +1,15 @@
 # Release History
 
-## 1.29.2 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
+## 1.29.2 (2023-08-14)
 
 ### Bugs Fixed
 
+- Added a default implementation for `AsyncTokenCredential.__aexit__()` #31573
+
 ### Other Changes
 
+- Bumped `typing-extensions` version to 4.6.0.
+
 ## 1.29.1 (2023-08-09)
 
 ### Bugs Fixed

sdk/core/azure-core/azure/core/credentials_async.py

@@ -3,7 +3,8 @@
 # Licensed under the MIT License.
 # ------------------------------------
 from __future__ import annotations
-from typing import Any, Optional, AsyncContextManager
+from types import TracebackType
+from typing import Any, Optional, AsyncContextManager, Type
 from typing_extensions import Protocol, runtime_checkable
 from .credentials import AccessToken as _AccessToken
 
@@ -31,3 +32,11 @@ async def get_token(
 
     async def close(self) -> None:
         pass
+
+    async def __aexit__(
+        self,
+        exc_type: Optional[Type[BaseException]] = None,
+        exc_value: Optional[BaseException] = None,
+        traceback: Optional[TracebackType] = None,
+    ) -> None:
+        pass

sdk/core/azure-core/setup.py

@@ -70,7 +70,7 @@
     install_requires=[
         "requests>=2.18.4",
         "six>=1.11.0",
-        "typing-extensions>=4.3.0",
+        "typing-extensions>=4.6.0",
     ],
     extras_require={
         "aio": [

sdk/core/azure-core/tests/async_tests/test_authentication_async.py

@@ -9,6 +9,7 @@
 from requests import Response
 
 from azure.core.credentials import AccessToken
+from azure.core.credentials_async import AsyncTokenCredential
 from azure.core.exceptions import ServiceRequestError
 from azure.core.pipeline import AsyncPipeline
 from azure.core.pipeline.policies import (
@@ -429,3 +430,13 @@ async def get_token(*_, **__):
     pipeline = AsyncPipeline(transport=MockTransport(), policies=[redirect_policy, auth_policy, header_clean_up_policy])
 
     await pipeline.run(HttpRequest("GET", "https://localhost"))
+
+
+@pytest.mark.asyncio
+async def test_async_token_credential_inheritance():
+    class TestTokenCredential(AsyncTokenCredential):
+        async def get_token(self, *scopes, **kwargs):
+            return "TOKEN"
+
+    cred = TestTokenCredential()
+    await cred.get_token("scope")