Allow sending false for enabled field under IAP message for resource google_compute_backend_service and resource google_compute_region_backend_service (GoogleCloudPlatform#11907)

Author: arnabadg-google

mmv1/products/compute/BackendService.yaml

@@ -754,6 +754,7 @@ properties:
         type: Boolean
         description: Whether the serving infrastructure will authenticate and authorize all incoming requests.
         required: true
+        send_empty_value: true
       - name: 'oauth2ClientId'
         type: String
         description: |

mmv1/products/compute/RegionBackendService.yaml

@@ -759,6 +759,7 @@ properties:
         type: Boolean
         description: Whether the serving infrastructure will authenticate and authorize all incoming requests.
         required: true
+        send_empty_value: true
       - name: 'oauth2ClientId'
         type: String
         description: |

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

@@ -146,6 +146,39 @@ func TestAccComputeBackendService_withBackendAndIAP(t *testing.T) {
 	})
 }
 
+func TestAccComputeBackendService_updateIAPEnabled(t *testing.T) {
+	t.Parallel()
+
+	serviceName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeBackendServiceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeBackendService_withIAPEnabled(
+					serviceName, 10),
+			},
+			{
+				ResourceName:            "google_compute_backend_service.lipsum",
+				ImportState:             true,
+				ImportStateVerify:       true,
+			},
+			{
+				Config: testAccComputeBackendService_withIAPDisabled(
+					serviceName, 10),
+			},
+			{
+				ResourceName:      "google_compute_backend_service.lipsum",
+				ImportState:       true,
+				ImportStateVerify: true,
+				ImportStateVerifyIgnore: []string{"iap.0.oauth2_client_secret"},
+			},
+		},
+	})
+}
+
 func TestAccComputeBackendService_updatePreservesOptionalParameters(t *testing.T) {
 	t.Parallel()
 
@@ -1370,6 +1403,40 @@ resource "google_compute_http_health_check" "default" {
 `, serviceName, timeout, igName, itName, checkName)
 }
 
+func testAccComputeBackendService_withIAPEnabled(
+	serviceName string, timeout int64) string {
+	return fmt.Sprintf(`
+resource "google_compute_backend_service" "lipsum" {
+  name        = "%s"
+  description = "Hello World 1234"
+  port_name   = "http"
+  protocol    = "HTTP"
+  timeout_sec = %v
+
+  iap {
+    enabled = true
+  }
+}
+`, serviceName, timeout)
+}
+
+func testAccComputeBackendService_withIAPDisabled(
+	serviceName string, timeout int64) string {
+	return fmt.Sprintf(`
+resource "google_compute_backend_service" "lipsum" {
+  name        = "%s"
+  description = "Hello World 1234"
+  port_name   = "http"
+  protocol    = "HTTP"
+  timeout_sec = %v
+
+  iap {
+    enabled = false
+  }
+}
+`, serviceName, timeout)
+}
+
 func testAccComputeBackendService_withSessionAffinity(serviceName, checkName, description, affinityName string) string {
 	return fmt.Sprintf(`
 resource "google_compute_backend_service" "foobar" {

mmv1/third_party/terraform/services/compute/resource_compute_region_backend_service_test.go.tmpl

@@ -283,6 +283,39 @@ func TestAccComputeRegionBackendService_withBackendAndIAP(t *testing.T) {
 	})
 }
 
+func TestAccComputeRegionBackendService_updateIAPEnabled(t *testing.T) {
+	t.Parallel()
+
+  serviceName := fmt.Sprintf("foo-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeRegionBackendServiceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeRegionBackendService_withIAPEnabled(
+					serviceName, 10),
+			},
+			{
+				ResourceName:            "google_compute_region_backend_service.foobar",
+				ImportState:             true,
+				ImportStateVerify:       true,
+			},
+			{
+				Config: testAccComputeRegionBackendService_withIAPDisabled(
+					serviceName, 10),
+			},
+			{
+				ResourceName:      "google_compute_region_backend_service.foobar",
+				ImportState:       true,
+				ImportStateVerify: true,
+				ImportStateVerifyIgnore: []string{"iap.0.oauth2_client_secret"},
+			},
+		},
+	})
+}
+
 func TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate(t *testing.T) {
 	t.Parallel()
 
@@ -1021,6 +1054,44 @@ resource "google_compute_health_check" "zero" {
 `, serviceName, drainingTimeout, checkName)
 }
 
+func testAccComputeRegionBackendService_withIAPEnabled(
+	serviceName string, timeout int64) string {
+	return fmt.Sprintf(`
+resource "google_compute_region_backend_service" "foobar" {
+  name        = "%s"
+  description = "Hello World 1234"
+  port_name   = "http"
+  protocol    = "HTTP"
+  load_balancing_scheme = "INTERNAL_MANAGED"
+  region      = "us-central1"
+  timeout_sec = %v
+
+  iap {
+    enabled = true
+  }
+}
+`, serviceName, timeout)
+}
+
+func testAccComputeRegionBackendService_withIAPDisabled(
+	serviceName string, timeout int64) string {
+	return fmt.Sprintf(`
+resource "google_compute_region_backend_service" "foobar" {
+  name        = "%s"
+  description = "Hello World 1234"
+  port_name   = "http"
+  protocol    = "HTTP"
+  load_balancing_scheme = "INTERNAL_MANAGED"
+  region      = "us-central1"
+  timeout_sec = %v
+
+  iap {
+    enabled = false
+  }
+}
+`, serviceName, timeout)
+}
+
 func testAccComputeRegionBackendService_ilbBasicwithIAP(serviceName, checkName string) string {
 	return fmt.Sprintf(`
 resource "google_compute_region_backend_service" "foobar" {