Skip to content

Commit 3e75c45

Browse files
author
dtolbert-bw
authored
Merge pull request #23 from Bandwidth/DX-666
Updated tollFreeWildCardPattern and quantity for search order requests
2 parents 65cc12d + d3a5260 commit 3e75c45

File tree

6 files changed

+17
-10
lines changed

6 files changed

+17
-10
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
dist: trusty
12
language: java
23
jdk:
34
- oraclejdk8

README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
Java SDK for Bandwidth's number management API.
44

5+
## Release Notes
6+
7+
| Version | Notes |
8+
|:---|:---|
9+
| 0.3.0 | Fixed `quantity` and `tollFreeWildCardPattern` for search requests |
10+
511
## Dependency
612

713
### Maven
@@ -58,6 +64,7 @@ AvailableNumberSearchRequest availableNumberSearchRequest = AvailableNumberSearc
5864
.city("CARY")
5965
.enableTNDetail(false)
6066
.quantity(10)
67+
.tollFreeWildCardPattern("8**")
6168
.build();
6269

6370
SearchResult searchResult = numbersClient.getAvailableTelephoneNumbers(availableNumberSearchRequest);
@@ -126,4 +133,4 @@ public class MyAwesomeBandwidthNumbersApp {
126133
}
127134
}
128135
}
129-
```
136+
```

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ publishing {
5151
maven(MavenPublication) {
5252
groupId = 'com.bandwidth.sdk'
5353
artifactId = 'numbers'
54-
version = '0.2.0-SNAPSHOT'
54+
version = '0.4.0-SNAPSHOT'
5555
from components.java
5656
}
5757
}
@@ -98,7 +98,7 @@ if (project.hasProperty("signing.keyId")) {
9898
// Configure group ID, artifact ID, and version
9999
group = "com.bandwidth.sdk"
100100
archivesBaseName = "numbers"
101-
version = "0.2.0-SNAPSHOT"
101+
version = "0.4.0-SNAPSHOT"
102102

103103
// Build, sign, and upload
104104
uploadArchives {

src/main/java/com/bandwidth/sdk/numbers/models/AvailableNumberSearchRequest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public abstract class AvailableNumberSearchRequest {
5252
public abstract String getTollFreeVanity();
5353

5454
@Nullable
55-
public abstract String getTollFreeVanityWildCardPattern();
55+
public abstract String getTollFreeWildCardPattern();
5656

5757
@Nullable
5858
public abstract Boolean getEnableTNDetail();
@@ -67,11 +67,7 @@ public abstract class AvailableNumberSearchRequest {
6767
public abstract OrderBy getOrderBy();
6868

6969
@Nullable
70-
@Value.Default
71-
@JacksonXmlProperty(localName = "Quantity")
72-
public Integer getQuantity() {
73-
return 1;
74-
}
70+
public abstract Integer getQuantity();
7571

7672
public static ImmutableAvailableNumberSearchRequest.Builder builder() {
7773
return ImmutableAvailableNumberSearchRequest.builder();

src/test/java/com/bandwidth/sdk/numbers/NumbersClientImplTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public class NumbersClientImplTest {
4343
.state("NC")
4444
.city("RALEIGH")
4545
.quantity(5)
46+
.tollFreeWildCardPattern("8**")
4647
.build();
4748

4849
private SearchResult searchResult = ImmutableSearchResult.builder()
@@ -178,4 +179,4 @@ public void orderNumbersWithError() {
178179
assertThat(thrown).isInstanceOf(NumbersApiException.class);
179180
}
180181

181-
}
182+
}

src/test/java/com/bandwidth/sdk/numbers/serde/NumbersSerdeTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ public class NumbersSerdeTest {
1212
private AvailableNumberSearchRequest availableNumberSearchRequest = AvailableNumberSearchRequest.builder()
1313
.city("RALEIGH")
1414
.state("NC")
15+
.tollFreeWildCardPattern("8**")
16+
.quantity(5)
1517
.enableTNDetail(true)
1618
.build();
1719

0 commit comments

Comments
 (0)