Merge pull request #40 from Bandwidth/DX-2405

DX-2405 Add support for missing JSON body body

Author: ajrice6713

bandwidth.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |s|
   s.homepage = 'https://apimatic.io'
   s.license = 'MIT'
   s.add_dependency('logging', '~> 2.3')
-  s.add_dependency('faraday', '~> 1.0', '<= 1.3.0')
+  s.add_dependency('faraday', '~> 1.0', '<= 1.9.3')
   s.add_dependency('faraday_middleware', '~> 1.0')
   s.add_dependency('certifi', '~> 2018.1', '>= 2018.01.18')
   s.add_dependency('faraday-http-cache', '~> 2.2')

lib/bandwidth/api_helper.rb

@@ -144,6 +144,7 @@ def self.clean_url(url)
     # Parses JSON string.
     # @param [String] A JSON string.
     def self.json_deserialize(json)
+      return {} if json.nil? || json.empty?
       JSON.parse(json)
     rescue StandardError
       raise TypeError, 'Server responded with invalid JSON.'

test/integration/test_integration.rb

@@ -38,6 +38,17 @@ def setup
             phone_number_lookup_basic_auth_user_name: BW_USERNAME,
             phone_number_lookup_basic_auth_password: BW_PASSWORD
         )
+
+        @bandwidth_client_invalid_auth = Bandwidth::Client.new(
+            voice_basic_auth_user_name: "bad_username",
+            voice_basic_auth_password: "bad_password",
+            messaging_basic_auth_user_name: "bad_username",
+            messaging_basic_auth_password: "bad_password",
+            multi_factor_auth_basic_auth_user_name: "bad_username",
+            multi_factor_auth_basic_auth_password: "bad_password",
+            phone_number_lookup_basic_auth_user_name: "bad_username",
+            phone_number_lookup_basic_auth_password: "bad_password"
+        )
     end
 
     def test_create_message
@@ -79,6 +90,19 @@ def test_upload_download_media
         assert_equal(downloaded_media, media, "Downloaded media file not equal to upload")
     end
 
+    def test_get_message
+        # Send a successful request to the GET messages API
+        response = @bandwidth_client.messaging_client.client.get_messages(BW_ACCOUNT_ID, :message_id => "abc123")
+        assert_equal(response.status_code, 200, "API did not return a 200 OK")
+    end 
+
+    def test_get_message_invalid_auth
+        # Send an unsuccessful request to the GET messages API
+        assert_raise MessagingException do
+            response = @bandwidth_client_invalid_auth.messaging_client.client.get_messages(BW_ACCOUNT_ID)
+        end
+    end 
+
     def test_create_call_and_get_call_state
         body = CreateCallRequest.new
         body.from = BW_NUMBER