Skip to content

Logging is done through System.out.println #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arngrimur-seal opened this issue Jun 26, 2019 · 1 comment
Closed

Logging is done through System.out.println #177

arngrimur-seal opened this issue Jun 26, 2019 · 1 comment

Comments

@arngrimur-seal
Copy link
Contributor

Logging using System.out.println is bad. It is not possible to filter and spams the test and production logs. Use java.util.logging (or better slf4j) instead of println for logging. This enables configurable logging and will still keep the project dependency free.
@arngrimur-seal arngrimur-seal mentioned this issue Jun 26, 2019
Merged
@steve-perkins
Copy link
Contributor

Agreed. The associated PR has been merged, and I've updated the README to reflects its inclusion in the (still pending) 4.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steve-perkins @arngrimur-seal