Merge branch 'small-keccak'

Author: benma

src/rust/Cargo.lock

@@ -34,6 +34,10 @@ hex = { version = "0.4", default-features = false, features = ["alloc"] }
 num-bigint = { version = "0.4.6", default-features = false }
 sha2 = { version = "0.10.8", default-features = false }
 sha3 = { version = "0.10.8", default-features = false }
+# We don't rely on this dep directly, the sha3 dep does. We list it here to enable the
+# no_unroll feature to reduce the binary size, saving around 1528 bytes (as measured at time of
+# writing, this might fluctuate over time).
+keccak = { version = "0.1.4", default-features = false, features = ["no_unroll"] }
 zeroize = "1.7.0"
 
 [patch.crates-io]

src/rust/Cargo.toml

@@ -32,7 +32,6 @@ p256 = { version = "0.13.2", default-features = false, features = ["arithmetic",
 der =  { version = "0.7.9", default-features = false, optional = true }
 hex = { workspace = true }
 sha2 = { workspace = true, optional = true }
-sha3 = { workspace = true, optional = true }
 bitcoin = { workspace = true, optional = true }
 
 [features]
@@ -73,8 +72,6 @@ testing = ["bitbox02-rust/testing", "bitbox02/testing"]
 c-unit-testing = ["bitbox02-rust/c-unit-testing", "bitbox02/c-unit-testing"]
 
 app-ethereum = [
-  # enable this dep
-  "sha3",
   # enable this feature in the deps
   "bitbox02-rust/app-ethereum",
   "bitbox02/app-ethereum",

src/rust/bitbox02-rust-c/Cargo.toml

@@ -36,6 +36,7 @@ streaming-silent-payments = { path = "../streaming-silent-payments", optional =
 hex = { workspace = true }
 sha2 = { workspace = true }
 sha3 = { workspace = true, optional = true }
+keccak = { workspace = true, optional = true }
 digest = "0.10.6"
 zeroize = { workspace = true }
 num-bigint = { workspace = true, optional = true }
@@ -71,6 +72,7 @@ ed25519 = [
 app-ethereum = [
   "dep:erc20_params",
   "dep:sha3",
+  "dep:keccak",
   "dep:num-bigint",
   "bitbox02/app-ethereum",
 ]