Skip to content

Absolute vs relative file path in node.yml #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielVoogsgerd opened this issue Sep 22, 2024 · 1 comment
Open

Absolute vs relative file path in node.yml #132

DanielVoogsgerd opened this issue Sep 22, 2024 · 1 comment

Comments

@DanielVoogsgerd
Copy link
Collaborator

DanielVoogsgerd commented Sep 22, 2024

In node.yml we specify the various paths a Brane instance will be using. These paths, right now, are absolute; should we create and or support relative paths as well? This way the configuration will be a lot more portable.

@Lut99
Copy link

Lut99 commented Oct 8, 2024

Sure, relative paths could also work! I don't think there's a need per sé to always keep them canonicalized.

Just be aware that Docker does require them to be absolute. So there'd have to be a little additional canonicalization by the time that containers are started and have volumes mounted (which I why I one day decided to just make everything absolute, out of convenience for the programmer). But it shouldn't be too hard to make them relative :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants