Skip to content

Commit f4edbcd

Browse files
committed
Set missing parameters to null to prevent error at import - Fixes #277
1 parent 1a9f011 commit f4edbcd

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

app/Services/Migrators/AegisMigrator.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ public function migrate(mixed $migrationPayload) : Collection
5252
$parameters['service'] = $otp_parameters['issuer'];
5353
$parameters['account'] = $otp_parameters['name'] ?? $parameters['service'];
5454
$parameters['secret'] = $this->padToValidBase32Secret($otp_parameters['info']['secret']);
55-
$parameters['algorithm'] = $otp_parameters['info']['algo'];
56-
$parameters['digits'] = $otp_parameters['info']['digits'];
55+
$parameters['algorithm'] = $otp_parameters['info']['algo'] ?? null;
56+
$parameters['digits'] = $otp_parameters['info']['digits'] ?? null;
5757
$parameters['counter'] = $otp_parameters['info']['counter'] ?? null;
5858
$parameters['period'] = $otp_parameters['info']['period'] ?? null;
5959

app/Services/Migrators/TwoFASMigrator.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,12 @@ public function migrate(mixed $migrationPayload) : Collection
8686
$parameters['service'] = $otp_parameters['name'];
8787
$parameters['account'] = $otp_parameters['otp']['account'] ?? $parameters['service'];
8888
$parameters['secret'] = $this->padToValidBase32Secret($otp_parameters['secret']);
89-
$parameters['algorithm'] = $otp_parameters['otp']['algorithm'];
90-
$parameters['digits'] = $otp_parameters['otp']['digits'];
91-
$parameters['counter'] = strtolower($parameters['otp_type']) === 'hotp' && $otp_parameters['otp']['counter'] > 0
89+
$parameters['algorithm'] = $otp_parameters['otp']['algorithm'] ?? null;
90+
$parameters['digits'] = $otp_parameters['otp']['digits'] ?? null;
91+
$parameters['counter'] = strtolower($parameters['otp_type']) === 'hotp' && Arr::has($otp_parameters['otp'], 'counter')
9292
? $otp_parameters['otp']['counter']
9393
: null;
94-
$parameters['period'] = strtolower($parameters['otp_type']) === 'totp' && $otp_parameters['otp']['period'] > 0
94+
$parameters['period'] = strtolower($parameters['otp_type']) === 'totp' && Arr::has($otp_parameters['otp'], 'period')
9595
? $otp_parameters['otp']['period']
9696
: null;
9797

app/Services/Migrators/TwoFAuthMigrator.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ public function migrate(mixed $migrationPayload) : Collection
5555
$parameters['service'] = $otp_parameters['service'];
5656
$parameters['account'] = $otp_parameters['account'];
5757
$parameters['secret'] = $this->padToValidBase32Secret($otp_parameters['secret']);
58-
$parameters['algorithm'] = $otp_parameters['algorithm'];
59-
$parameters['digits'] = $otp_parameters['digits'];
58+
$parameters['algorithm'] = $otp_parameters['algorithm'] ?? null;
59+
$parameters['digits'] = $otp_parameters['digits'] ?? null;
6060
$parameters['legacy_uri'] = $otp_parameters['legacy_uri'];
6161
$parameters['counter'] = strtolower($parameters['otp_type']) === 'hotp' && $otp_parameters['counter'] > 0
6262
? $otp_parameters['counter']

0 commit comments

Comments
 (0)