chore: correct typo and metric names

Author: twoeths

src/index.ts

@@ -2172,7 +2172,7 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
       // else, Message not in cache. Ignoring forwarding
     }
 
-    const firstSeenTimestampMs = this.score.messageFirstSeeenTimestampMs(msgId)
+    const firstSeenTimestampMs = this.score.messageFirstSeenTimestampMs(msgId)
     this.metrics?.onReportValidation(cacheEntry, acceptance, firstSeenTimestampMs)
   }
 

src/metrics.ts

@@ -249,15 +249,15 @@ export function getMetrics(
       labelNames: ['hit']
     }),
 
-    asyncValidationDelayFromFirstSeen: register.histogram<{ topic: TopicLabel }>({
+    asyncValidationDelayFromFirstSeenSec: register.histogram<{ topic: TopicLabel }>({
       name: 'gossipsub_async_validation_delay_from_first_seen',
-      help: 'Async validation report delay from first seen',
+      help: 'Async validation report delay from first seen in second',
       labelNames: ['topic'],
       buckets: [0.01, 0.03, 0.1, 0.3, 1, 3, 10]
     }),
 
     asyncValidationUnknownFirstSeen: register.gauge({
-      name: 'gossipsub_async_validation_unknown_first_seen',
+      name: 'gossipsub_async_validation_unknown_first_seen_count_total',
       help: 'Async validation report unknown first seen value for message'
     }),
 
@@ -588,7 +588,10 @@ export function getMetrics(
       this.meshPeerChurnEvents.inc({ topic, reason }, count)
     },
 
-    // null messageRecord means the message's mcache record was not known at the time of acceptance report
+    /**
+     * Update validation result to metrics
+     * @param messageRecord null means the message's mcache record was not known at the time of acceptance report
+     */
     onReportValidation(
       messageRecord: { message: { topic: TopicStr } } | null,
       acceptance: TopicValidatorResult,
@@ -598,11 +601,11 @@ export function getMetrics(
 
       if (messageRecord != null) {
         const topic = this.toTopic(messageRecord.message.topic)
-        this.asyncValidationResult.inc({ topic: topic, acceptance })
+        this.asyncValidationResult.inc({ topic, acceptance })
       }
 
       if (firstSeenTimestampMs != null) {
-        this.asyncValidationDelayFromFirstSeen.observe((Date.now() - firstSeenTimestampMs) / 1000)
+        this.asyncValidationDelayFromFirstSeenSec.observe((Date.now() - firstSeenTimestampMs) / 1000)
       } else {
         this.asyncValidationUnknownFirstSeen.inc()
       }

src/score/peer-score.ts

@@ -100,7 +100,7 @@ export class PeerScore {
     return Object.fromEntries(Array.from(this.peerStats.entries()).map(([peer, stats]) => [peer, stats]))
   }
 
-  messageFirstSeeenTimestampMs(msgIdStr: MsgIdStr): number | null {
+  messageFirstSeenTimestampMs(msgIdStr: MsgIdStr): number | null {
     const drec = this.deliveryRecords.getRecord(msgIdStr)
     return drec ? drec.firstSeenTsMs : null
   }