Skip to content

Commit 70034a2

Browse files
authored
Minor optimization and style fixes
1 parent 551cd04 commit 70034a2

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

clickhouse/columns/tuple.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,22 @@ void ColumnTuple::Append(ColumnRef column) {
2626
"can't append column of type " + column->Type()->GetName() + " "
2727
"to column type " + this->Type()->GetName());
2828
}
29-
for (size_t ci = 0; ci < columns_.size(); ci++) {
30-
columns_[ci]->Append((*column->As<ColumnTuple>())[ci]);
29+
const auto & source_tuple_column = column->As<ColumnTuple>();
30+
for (size_t ci = 0; ci < columns_.size(); ++ci) {
31+
columns_[ci]->Append((*source_tuple_column)[ci]);
3132
}
3233
}
3334
size_t ColumnTuple::Size() const {
3435
return columns_.empty() ? 0 : columns_[0]->Size();
3536
}
3637
ColumnRef ColumnTuple::Slice(size_t begin, size_t len) const {
37-
std::vector<ColumnRef> slicedColumns;
38+
std::vector<ColumnRef> sliced_columns;
39+
sliced_columns.reserve(columns_.size());
3840
for(const auto &column : columns_){
39-
slicedColumns.push_back(column->Slice(begin, len));
41+
sliced_columns.push_back(column->Slice(begin, len));
4042
}
4143

42-
return std::make_shared<ColumnTuple>(slicedColumns);
44+
return std::make_shared<ColumnTuple>(sliced_columns);
4345
}
4446

4547
bool ColumnTuple::Load(InputStream* input, size_t rows) {

0 commit comments

Comments
 (0)