Skip to content

Recurrent layer support for Online policy algorithms #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bharath2 opened this issue Aug 22, 2021 · 1 comment
Closed

Recurrent layer support for Online policy algorithms #550

Bharath2 opened this issue Aug 22, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@Bharath2
Copy link

Bharath2 commented Aug 22, 2021

🚀 Feature

Please add Recurrent layer Support for PPO and A2C

Motivation

I am working on agile 3d biped locomotion. I feel that PPO with a recurrent layer like LSTM will greatly help.

Pitch

Stable-baselines tensorflow version have options like MlpLSTMPolicy for algorithms like PPO2 and A2C.
I can see in the source code of stable-baselines3 that the predict method of BasePolicy class has some provision for recurrent policies, But the OnPolicyAlgorithm class does not take that in to account.

I would also like to contribute to this.

Checklist

  • [y] I have checked that there is no similar issue in the repo
@Bharath2 Bharath2 added the enhancement New feature or request label Aug 22, 2021
@Miffyli
Copy link
Collaborator

Miffyli commented Aug 22, 2021

Duplicate of #18 and #160, closing as such.

Yup they would be cool to have, but nobody has had the time to come around to implement them yet (also the benefit of LSTMs outside complex tasks is questionable, see this and bottom of this). Try framestacking meanwhile.

@Miffyli Miffyli closed this as completed Aug 22, 2021
@Miffyli Miffyli added the duplicate This issue or pull request already exists label Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants