Skip to content

Commit 876d9a8

Browse files
yufan-suDawid212
authored andcommitted
Set return_partial_success=true in GKE Hub GetFeature call to ensure partial results are returned when a region is down (GoogleCloudPlatform#13453)
1 parent aa89ba1 commit 876d9a8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

mmv1/products/gkehub2/Feature.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ references:
2222
docs:
2323
id_format: 'projects/{{project}}/locations/{{location}}/features/{{name}}'
2424
base_url: 'projects/{{project}}/locations/{{location}}/features'
25-
self_link: 'projects/{{project}}/locations/{{location}}/features/{{name}}'
25+
self_link: 'projects/{{project}}/locations/{{location}}/features/{{name}}?return_partial_success=true'
2626
create_url: 'projects/{{project}}/locations/{{location}}/features?featureId={{name}}'
27+
delete_url: 'projects/{{project}}/locations/{{location}}/features/{{name}}'
2728
update_url: 'projects/{{project}}/locations/{{location}}/features/{{name}}'
2829
update_verb: 'PATCH'
2930
update_mask: true
@@ -44,6 +45,7 @@ async:
4445
iam_policy:
4546
method_name_separator: ':'
4647
parent_resource_attribute: 'name'
48+
base_url: 'projects/{{project}}/locations/{{location}}/features/{{name}}'
4749
example_config_body: 'templates/terraform/iam/iam_attributes.go.tmpl'
4850
import_format:
4951
- 'projects/{{project}}/locations/{{location}}/features/{{name}}'

mmv1/third_party/tgc/tests/data/example_gke_hub_feature.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[
22
{
3-
"name": "//gkehub.googleapis.com/projects/{{.Provider.project}}/locations/global/features/multiclusterservicediscovery",
3+
"name": "//gkehub.googleapis.com/projects/{{.Provider.project}}/locations/global/features/multiclusterservicediscovery?return_partial_success=true",
44
"ancestry_path": "{{.Ancestry}}/project/{{.Provider.project}}",
55
"asset_type": "gkehub.googleapis.com/Feature",
66
"resource": {

0 commit comments

Comments
 (0)