You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add a function to dfm_tools that generates a bc file with source sinks and also updates the extfile, based on some arbitrary input variables (discharge, sal, tem, NO3, maybe vary constant/timeseries) and an x/y coordinate (or pli)
print warning when calling the function that it only works from delft3dfm version so-and-so (date so-and-so), since this is very new stuff and most users don't have access to this version of delft3dfm yet
add minimal example in the modelbuilder notebook that works anywhere globally (for now, disable by default because of the previous point)
workflow: create a branch from this issue, commit things, open a PR from that branch, request review when first iteration is done
opening a PR also kicks off the testbanks on every commit, you can save CO2 by cancelling them if you are not interested in the result. Or wait with opening the PR until the branch contains a working proof of concept. Both are fine.
keep track of code quality (analysed on each push to a PR by sonarcloud)
make sure to cover new code with tests (analysed by codecov after every successful github pytest workflow run)
after a PR is created, each push to the branch will trigger the pytest github workflows, these can be tracked here
The text was updated successfully, but these errors were encountered:
Relevant info:
[Forcing]
blocks, these can also be merged into one if desired.Todo:
Contributing guidelines:
The text was updated successfully, but these errors were encountered: