Skip to content

Add source sinks in bc format #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
veenstrajelmer opened this issue Mar 26, 2025 · 0 comments
Open
4 tasks

Add source sinks in bc format #1167

veenstrajelmer opened this issue Mar 26, 2025 · 0 comments

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Mar 26, 2025

Relevant info:

Todo:

  • add a function to dfm_tools that generates a bc file with source sinks and also updates the extfile, based on some arbitrary input variables (discharge, sal, tem, NO3, maybe vary constant/timeseries) and an x/y coordinate (or pli)
  • print warning when calling the function that it only works from delft3dfm version so-and-so (date so-and-so), since this is very new stuff and most users don't have access to this version of delft3dfm yet
  • add minimal example in the modelbuilder notebook that works anywhere globally (for now, disable by default because of the previous point)
  • update whatsnew

Contributing guidelines:

  • general contributing information available here (too much info, so cherry pick): https://deltares.github.io/dfm_tools/CONTRIBUTING.html
  • workflow: create a branch from this issue, commit things, open a PR from that branch, request review when first iteration is done
  • opening a PR also kicks off the testbanks on every commit, you can save CO2 by cancelling them if you are not interested in the result. Or wait with opening the PR until the branch contains a working proof of concept. Both are fine.
  • keep track of code quality (analysed on each push to a PR by sonarcloud)
  • make sure to cover new code with tests (analysed by codecov after every successful github pytest workflow run)
  • after a PR is created, each push to the branch will trigger the pytest github workflows, these can be tracked here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant