updated PING and ECHO stubs

srinivas-tanla · srinivas-tanla · commit 858d8b0066e1 · 2025-03-27T14:14:30.000+05:30
diff --git a/internal/eval/eval.go b/internal/eval/eval.go
@@ -144,11 +144,18 @@ func evalSLEEP(args []string, store *dstore.Store) []byte {
 }
 
 func evalPING(args []string, store *dstore.Store) []byte {
-	return nil
+	// PING command returns PONG if no argument is provided, otherwise it returns the argument
+	if len(args) == 0 {
+		return Encode("PONG", false)
+	}
+	return Encode(args[0], false)
 }
 
 func evalECHO(args []string, store *dstore.Store) []byte {
-	return nil
+	if len(args) == 1 {
+		return diceerrors.NewErrArity("ECHO")
+	}
+	return Encode(args[0], false)
 }
 
 func evalSET(args []string, store *dstore.Store) *EvalResponse {

Original file line number	Diff line number	Diff line change
`@@ -144,11 +144,18 @@ func evalSLEEP(args []string, store *dstore.Store) []byte {`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`func evalPING(args []string, store *dstore.Store) []byte {`
`147`		`- return nil`
	`147`	`+ // PING command returns PONG if no argument is provided, otherwise it returns the argument`
	`148`	`+ if len(args) == 0 {`
	`149`	`+ return Encode("PONG", false)`
	`150`	`+ }`
	`151`	`+ return Encode(args[0], false)`
`148`	`152`	`}`
`149`	`153`
`150`	`154`	`func evalECHO(args []string, store *dstore.Store) []byte {`
`151`		`- return nil`
	`155`	`+ if len(args) == 1 {`
	`156`	`+ return diceerrors.NewErrArity("ECHO")`
	`157`	`+ }`
	`158`	`+ return Encode(args[0], false)`
`152`	`159`	`}`
`153`	`160`
`154`	`161`	`func evalSET(args []string, store dstore.Store) EvalResponse {`