Opentel change port number

Author: gsarmaonline

Makefile

@@ -74,7 +74,7 @@ run: ## run dicedb with the default configuration
 	go run main.go --engine ironhawk --log-level debug
 
 run-docker: ## run dicedb in a Docker container
-	docker run -p 7379:7379 dicedb/dicedb:latest
+	docker run -p 7379:7379 -p 8050:8050 dicedb/dicedb:latest
 
 format: ## format the code using go fmt
 	go fmt ./...

internal/diceotel/diceotel.go

@@ -14,7 +14,7 @@ import (
 
 const (
 	meterName    = "dicedb-otel"
-	diceOtelPort = "9090"
+	diceOtelPort = "8050"
 )
 
 type (
@@ -78,6 +78,7 @@ func (dotel *DiceOtel) Run() (err error) {
 func (dotel *DiceOtel) serveMetrics() (err error) {
 	http.Handle("/metrics", promhttp.Handler())
 	if err = http.ListenAndServe(":"+diceOtelPort, nil); err != nil {
+		log.Println("Error starting Diceotel server", err)
 		return
 	}
 	return

internal/diceotel/metrics.go

@@ -7,10 +7,14 @@ import (
 var (
 	// Counters
 	DiceStartCounter api.Int64Counter
+
+	// Histograms
+	DiceCmdLatencyInMsHistogram api.Int64Histogram
 )
 
 func (dotel *DiceOtel) register() (err error) {
-	DiceStartCounter, _ = dotel.Meter.Int64Counter("dicedb_start", api.WithDescription("A counter for the start of the DiceDB server"))
-	// Add other metrics here
+	DiceStartCounter, _ = dotel.Meter.Int64Counter("dicedb.start.count", api.WithDescription("A counter for the start of the DiceDB server"))
+	DiceCmdLatencyInMsHistogram, _ = dotel.Meter.Int64Histogram("dicedb.command_exec.latency", api.WithUnit("ms"))
+	// Add new metrics here
 	return
 }

internal/diceotel/prometheus-grafana/docker-compose.yml

@@ -1,7 +1,3 @@
-# docker-compose.yml
-
-version: '3.8'
-
 services:
   prometheus:
     image: prom/prometheus
@@ -25,16 +21,5 @@ services:
       - GF_SECURITY_ADMIN_PASSWORD=grafana
     volumes:
       - ./grafana:/etc/grafana/provisioning/datasources
-  generate_prom_metrics:
-    build:
-      context: .
-      dockerfile: Dockerfile
-    container_name: generate_prom_metrics
-    command: 'python app/tests/test_prom_scraping.py'
-    volumes:
-      - .:/app
-    ports:
-      - 8050:8050 
-    restart: unless-stopped
 volumes:
   prom_data:

internal/server/ironhawk/iothread.go

@@ -7,9 +7,13 @@ import (
 	"context"
 	"log/slog"
 	"strings"
+	"time"
 
 	"github.com/dicedb/dice/internal/auth"
 	"github.com/dicedb/dice/internal/cmd"
+	"github.com/dicedb/dice/internal/diceotel"
+	"go.opentelemetry.io/otel/attribute"
+	"go.opentelemetry.io/otel/metric"
 )
 
 type IOThread struct {
@@ -42,10 +46,20 @@ func (t *IOThread) StartSync(ctx context.Context, shardManager *ShardManager, wa
 		_c.ClientID = t.ClientID
 		_c.Mode = t.Mode
 
+		execStartTime := time.Now()
 		res, err := shardManager.Execute(_c)
 		if err != nil {
 			res.R.Err = err.Error()
 		}
+		diceotel.DiceCmdLatencyInMsHistogram.Record(
+			ctx,
+			time.Since(execStartTime).Milliseconds(),
+			metric.WithAttributeSet(
+				attribute.NewSet(
+					attribute.String("cmd", c.Cmd),
+				),
+			),
+		)
 		// TODO: Optimize this. We are doing this for all command execution
 		// Also, we are allowing people to override the client ID.
 		// Also, CLientID is duplicated in command and io-thread.