fix(syntax): Fix highlight for json labels #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the Treesitter module, the group `@label.json` was previously using `fg = spec.func` to color JSON labels as functions. However the spec `func` is nested in `spec.syntax.func` not in `spec.func`, which caused incorrect highlighting of JSON labels. By using `syn.func`, which correctly points to `spec.syntax.func`, the issue is now resolved.
|
By the way, for those who wish to address the issue in their configuration temporarily, until the fix is available: require("nightfox").setup({
groups = {
all = {
["@label.json"] = { fg = "syntax.func" },
}
}
}) |
EdenEast
approved these changes
Jul 31, 2023
|
Thanks for the PR LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the Treesitter module, the group
@label.jsonwas previously usingfg = spec.functo color JSON labels as functions.However the spec
funcis nested inspec.syntax.funcnot inspec.func, which caused incorrect highlighting of JSON labels.By using
syn.func, which correctly points tospec.syntax.func, the issue is now resolved.Before commit
After commit