return by emplace_back

Turns out it doesn't return void like push_back.

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

src/crwimage_int.cpp

@@ -134,8 +134,7 @@ const CiffComponent::UniquePtr& CiffEntry::doAdd(UniquePtr /*component*/) {
 }  // CiffEntry::doAdd
 
 const CiffComponent::UniquePtr& CiffDirectory::doAdd(UniquePtr component) {
-  components_.push_back(std::move(component));
-  return components_.back();
+  return components_.emplace_back(std::move(component));
 }  // CiffDirectory::doAdd
 
 void CiffHeader::read(const byte* pData, size_t size) {

src/exif.cpp

@@ -443,8 +443,7 @@ Exifdatum& ExifData::operator[](const std::string& key) {
   ExifKey exifKey(key);
   auto pos = findKey(exifKey);
   if (pos == end()) {
-    exifMetadata_.emplace_back(exifKey);
-    return exifMetadata_.back();
+    return exifMetadata_.emplace_back(exifKey);
   }
   return *pos;
 }

src/iptc.cpp

@@ -209,8 +209,7 @@ Iptcdatum& IptcData::operator[](const std::string& key) {
   IptcKey iptcKey(key);
   auto pos = findKey(iptcKey);
   if (pos == end()) {
-    iptcMetadata_.emplace_back(iptcKey);
-    return iptcMetadata_.back();
+    return iptcMetadata_.emplace_back(iptcKey);
   }
   return *pos;
 }

src/tiffcomposite_int.cpp

@@ -551,17 +551,15 @@ TiffComponent* TiffComponent::doAddChild(UniquePtr /*tiffComponent*/) {
 }  // TiffComponent::doAddChild
 
 TiffComponent* TiffDirectory::doAddChild(TiffComponent::UniquePtr tiffComponent) {
-  components_.push_back(std::move(tiffComponent));
-  return components_.back().get();
+  return components_.emplace_back(std::move(tiffComponent)).get();
 }  // TiffDirectory::doAddChild
 
 TiffComponent* TiffSubIfd::doAddChild(TiffComponent::UniquePtr tiffComponent) {
   auto d = dynamic_cast<TiffDirectory*>(tiffComponent.release());
   if (!d) {
     throw Error(ErrorCode::kerErrorMessage, "dynamic_cast to TiffDirectory failed");
   }
-  ifds_.emplace_back(d);
-  return d;
+  return ifds_.emplace_back(d).get();
 }  // TiffSubIfd::doAddChild
 
 TiffComponent* TiffMnEntry::doAddChild(TiffComponent::UniquePtr tiffComponent) {
@@ -576,9 +574,8 @@ TiffComponent* TiffIfdMakernote::doAddChild(TiffComponent::UniquePtr tiffCompone
 }
 
 TiffComponent* TiffBinaryArray::doAddChild(TiffComponent::UniquePtr tiffComponent) {
-  elements_.push_back(std::move(tiffComponent));
   setDecoded(true);
-  return elements_.back().get();
+  return elements_.emplace_back(std::move(tiffComponent)).get();
 }  // TiffBinaryArray::doAddChild
 
 TiffComponent* TiffComponent::addNext(TiffComponent::UniquePtr tiffComponent) {

src/xmp.cpp

@@ -421,8 +421,7 @@ Xmpdatum& XmpData::operator[](const std::string& key) {
   XmpKey xmpKey(key);
   auto pos = findKey(xmpKey);
   if (pos == end()) {
-    xmpMetadata_.emplace_back(xmpKey);
-    return xmpMetadata_.back();
+    return xmpMetadata_.emplace_back(xmpKey);
   }
   return *pos;
 }