Skip to content

Missing options in meson build #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heitbaum opened this issue Jul 10, 2024 · 2 comments · May be fixed by #3265
Open

Missing options in meson build #3015

heitbaum opened this issue Jul 10, 2024 · 2 comments · May be fixed by #3265

Comments

@heitbaum
Copy link

Describe the bug

A clear and concise description of the bug, including your use case for exiv2.

the following options are missing in the meson build (as compared to cmake)

  • EXIV2_ENABLE_FILESYSTEM_ACCESS
  • EXIV2_BUILD_EXIV2_COMMAND
  • EXIV2_BUILD_EXIV2_EXAMPLES

To Reproduce

Steps to reproduce the behavior:

  1. Provide the file with which you observed the issue (commonly named PoC). Explain the status of the file (e.g., direct from camera, edited with darktable), whether you own the copyright and if you allow the file to be added to exiv2 under the project's license
  2. List the exact commands/functions to reproduce the issue and include any related output
  3. Mention the branch and commit in which you observed the issue (e.g., main, commit 9f721b40, 0.27-maintenance, latest)

using 0.28.3

Expected behavior

A short description of what you expected to happen.

Meson options should mirror Cmake

Desktop (please complete the following information):

  • OS and version: (e.g., Linux (Fedora 36), macOS 12.5, Windows 11) Linux (Ubuntu 24.04)
  • Exiv2 version and source: (e.g., 0.27.5 from exiv2.org) 0.28.3
  • Compiler and version: (e.g., Gcc 12.2, Clang 14.0.0, MSVC 2022) gcc-14.1.0
  • Compilation mode and/or compiler flags: (e.g., debug, -O3)

Additional context

Add any other information about the problem here.

@neheb
Copy link
Collaborator

neheb commented Apr 26, 2025

correct. How desired are these to be configurable?

The samples only really make sense in the context of tests.

@heitbaum
Copy link
Author

In our building we have all of these set to OFF, so if the meson build could allow for that.
Allowing for unitTests, fuzz, app and samples directories to NOT be built (the same as CMake would be great.

@neheb neheb linked a pull request Apr 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants