Compatibility check was not properly checking version gap

Author: FMCorz

classes/local/plugin/addon.php

@@ -47,15 +47,6 @@ final public function get_release() {
         return $localxp ? $localxp->release : '-';
     }
 
-    /**
-     * Get the version difference.
-     *
-     * @return int
-     */
-    public function get_version_diff() {
-        return 0;
-    }
-
     /**
      * Whether the plugin is activated.
      *

classes/local/setting/compatibility_check_setting.php

@@ -59,8 +59,23 @@ protected function get_html_content() {
 
         $blockxp = $pluginman->get_plugin_info('block_xp');
         $localxp = $pluginman->get_plugin_info('local_xp');
+        $recentishlocalxp = 2023100800; // v1.15.0.
         $humanbranch = moodle_major_version() ?: 'v?';
 
+        if ($localxp && $localxp->versiondb < $recentishlocalxp) {
+            $messages[] = [
+                'title' => get_string('outofsyncexcessive', 'block_xp'),
+                'message' => get_string('outofsyncexcessiveinfo', 'block_xp'),
+                'url' => 'https://docs.levelup.plus/xp/docs/requirements-compatibility#out-of-sync',
+            ];
+        } else if ($addon->is_out_of_sync()) {
+            $messages[] = [
+                'title' => get_string('outofsync', 'block_xp'),
+                'message' => get_string('outofsyncinfo', 'block_xp'),
+                'url' => 'https://docs.levelup.plus/xp/docs/requirements-compatibility#out-of-sync',
+            ];
+        }
+
         if ($CFG->branch >= 39) {
             if (!empty($blockxp->pluginsupported) && ($CFG->branch < $blockxp->pluginsupported[0]
                     || $CFG->branch > $blockxp->pluginsupported[1])) {
@@ -82,20 +97,6 @@ protected function get_html_content() {
             }
         }
 
-        if ($addon->get_version_diff() > 270) {
-            $messages[] = [
-                'title' => get_string('outofsyncexcessive', 'block_xp'),
-                'message' => get_string('outofsyncexcessiveinfo', 'block_xp'),
-                'url' => 'https://docs.levelup.plus/xp/docs/requirements-compatibility#out-of-sync',
-            ];
-        } else if ($addon->is_out_of_sync()) {
-            $messages[] = [
-                'title' => get_string('outofsync', 'block_xp'),
-                'message' => get_string('outofsyncinfo', 'block_xp'),
-                'url' => 'https://docs.levelup.plus/xp/docs/requirements-compatibility#out-of-sync',
-            ];
-        }
-
         return di::get('renderer')->render_from_template('block_xp/admin-compatibility-check', [
             'haswarnings' => !empty($messages),
             'warnings' => $messages,