Skip to content

Break out EthNodeHandle utilities from relayer tests to shared test helper module #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
netrome opened this issue Mar 21, 2025 · 0 comments
Open

Break out EthNodeHandle utilities from relayer tests to shared test helper module #2894

netrome opened this issue Mar 21, 2025 · 0 comments
Assignees
@netrome
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@netrome
Copy link
Contributor

netrome commented Mar 21, 2025

Context

The state root service wraps a relayer, and needs the same utilities for its integration tests. Currently, I've copy-pasted the utilities to the state root service integration tests, but best would be if we could share them.

Definition of done.

The EthNodeHandle and it's associated functions are moved to a shared module so they can be reused.
@netrome netrome added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Mar 21, 2025
@netrome netrome self-assigned this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netrome netrome

Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@netrome