Modify client coins endpoint so None for asset_id returns all asset_ids instead of AssetId::default()

[MitchTurner]

Currently the coins endpoint on the client will request AssetId::default() if asset_id field is None. This is not expected behavior, and even the query side expects to return all if None:

let coins = query
                .owned_coins(&owner, (*start).map(Into::into), direction)
                .filter_map(|result| {
                    if let (Ok(coin), Some(filter_asset_id)) = (&result, &filter.asset_id)
                    {
                        if *coin.asset_id() != filter_asset_id.0 {
                            return None
                        }
                    }

                    Some(result)
                })
                .map(|res| res.map(|coin| ((*coin.utxo_id()).into(), coin.into())));

            Ok(coins)

We should consider removing this code from coins:

        let asset_id: schema::AssetId = match asset_id {
            Some(asset_id) => (*asset_id).into(),
            None => schema::AssetId::default(),
        };

[MitchTurner]

Also, it's not clear that AssetId::default() is the base asset. That's also a bug.

[EDOHWARES]

Hi, I'm EDOHWAREZ, a software developer with years of experience in building scalable software. I'll like to work on this issue.