lots of failing tests with pytest-asyncio-0.19.0

[mm1ke]

Hi,

I'm having some troubles with the gns3 tests with the latest pytest-asyncio (0.19.0 to be precise). Many tests start to fail with errors like AttributeError: 'coroutine' object has no attribute '_create_netmap_config'. Running these tests with pytest-asyncio-0.18.3 works without any failed tests.
I had a look at the changes for pytest-asyncio and the only breaking changed seemed to be the change to use strict mode by default, see: pytest-dev/pytest-asyncio#380
Another hint in this direction seems to be: pytest-dev/pytest-asyncio#390
However, i really have no idea if that is the case here, but i hope this can be fixed somehow, otherwise i would need to restrict the pytest-asyncio version on gentoo. While it would work as a temporally fix, it's also frowned up and only would make it more difficult in the future.

Our bug report with additional information can be found here: https://bugs.gentoo.org/863770

[grossmj]

Thanks for reporting this. My quick guess is that we haven't explicitly marked all the tests that are coroutines with @pytest.mark.asyncio and now the strict mode enforces it.

I will check soon and fix this soon.

[seifertm]

Sorry that the pytest-asyncio update causes trouble, but it was necessary.

The old behavior (legacy mode) caused compatibility problems for projects that wanted to support multiple async frameworks. We deprecated legacy mode at the beginning of this year and switched the default mode to strict in v0.19, which requires tests and fixtures to be explicitly marked.

Here's the relevant section in the docs:
https://github.com/pytest-dev/pytest-asyncio/tree/v0.19.0#modes

[grossmj]

@mm1ke is this issue for version 3.0 or 2.2.x?

@seifertm no worries, we understand :)

[mm1ke]

@grossmj this happens with 2.2.x

[grossmj]

Fixed for both 3.0 and 2.2.x