-
Notifications
You must be signed in to change notification settings - Fork 1.7k
disasm() doesn't work for context.arch='sparc64' #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
On Sun, Jun 07, 2020 at 12:14:40PM -0700, Zach Riggle wrote:
I can't reproduce this.
```
>>> context.clear(arch='sparc64')
>>> asm('nop')
'\x01\x00\x00\x00'
```
```
>>> context.clear(arch='mips64')
>>> asm('nop')
[!] Could not find system include headers for mips64-linux
'\x00\x00\x00\x00'
```
```
>>> context.clear(arch='powerpc64')
>>> asm('nop')
'`\x00\x00\x00'
```
Please note that the issue happens when calling `disasm`, not `asm`.
|
@zachriggle Bump. I think you closed this by mistake. |
Yep not sure what happened. If you know why this is failing, a pull request would be nice! |
Sorry, I didn't have the time to investigate this properly yet. |
Can you take a look at #1603 and see if that fixes the issue for you? |
I can confirm that it indeed made this work. The fix makes me wonder whether this will properly assemble for 64 bits, but I couldn't come up with a simple way to test this, so I will assume that this is handled by the bfd name. |
* [asm] Fix disasm() for mips64, powerpc64, sparc64 Closes #1564 * [asm] Add tests for disasm on mips/powerpc/sparc 64-bit * [asm] Find powerpc, sparc, mips utilities even for 64-bit variants * [asm] Remove leftover debug trace * [ci] Add Sparc64 binutils * [changelog] Add entry
The text was updated successfully, but these errors were encountered: