Skip to content

Commit 7b01899

Browse files
committed
fix: delete icon hanged with bordered icon
1 parent 5bd6c48 commit 7b01899

File tree

7 files changed

+19
-27
lines changed

7 files changed

+19
-27
lines changed

admin-ui/plugins/admin/components/CustomScripts/ScriptListPage.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react'
2-
import MaterialTable from '@material-table/core';
2+
import MaterialTable from '@material-table/core'
3+
import { DeleteOutlined } from '@material-ui/icons'
34
import { useHistory } from 'react-router-dom'
45
import { Paper } from '@material-ui/core'
56
import { Badge } from 'reactstrap'
@@ -76,7 +77,6 @@ function ScriptListTable({ scripts, loading, dispatch, permissions }) {
7677
myActions.push((rowData) => ({
7778
icon: 'edit',
7879
iconProps: {
79-
color: 'primary',
8080
id: 'editCustomScript' + rowData.inum,
8181
},
8282
tooltip: `${t('messages.edit_script')}`,
@@ -115,9 +115,8 @@ function ScriptListTable({ scripts, loading, dispatch, permissions }) {
115115
}
116116
if (hasPermission(permissions, SCRIPT_DELETE)) {
117117
myActions.push((rowData) => ({
118-
icon: 'delete',
118+
icon: () => <DeleteOutlined />,
119119
iconProps: {
120-
color: 'secondary',
121120
id: 'deleteCustomScript' + rowData.inum,
122121
},
123122
tooltip: `${t('messages.delete_script')}`,

admin-ui/plugins/admin/components/Mapping/MappingItem.js

+4-9
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99
Form,
1010
} from '../../../../app/components'
1111
import { useDispatch, useSelector } from 'react-redux'
12+
import { DeleteOutlined } from '@material-ui/icons'
1213
import {
1314
updateMapping,
1415
addPermissionsToRole,
@@ -96,19 +97,13 @@ function MappingItem({ candidate }) {
9697
<Accordion.Indicator className="mr-2" />
9798
{candidate.role}
9899

99-
<Button
100-
type="button"
101-
color="danger"
100+
<DeleteOutlined
102101
onClick={() => handleDeleteRole()}
103102
style={{
104-
margin: '1px',
105103
float: 'right',
106-
padding: '0px',
104+
color: '#000',
107105
}}
108-
>
109-
<i className="fa fa-trash mr-2"></i>
110-
Delete
111-
</Button>
106+
/>
112107
<Badge
113108
color="info"
114109
style={{

admin-ui/plugins/auth-server/components/Clients/ClientListPage.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react'
22
import MaterialTable from '@material-table/core'
3+
import { DeleteOutlined } from '@material-ui/icons'
34
import { useHistory } from 'react-router-dom'
45
import { connect } from 'react-redux'
56
import { Paper } from '@material-ui/core'
@@ -130,7 +131,6 @@ function ClientListPage({ clients, permissions, scopes, loading, dispatch }) {
130131
myActions.push((rowData) => ({
131132
icon: 'edit',
132133
iconProps: {
133-
color: 'primary',
134134
id: 'editClient' + rowData.inum,
135135
},
136136
tooltip: `${t('messages.edit_client')}`,
@@ -174,7 +174,6 @@ function ClientListPage({ clients, permissions, scopes, loading, dispatch }) {
174174
myActions.push((rowData) => ({
175175
icon: 'visibility',
176176
iconProps: {
177-
color: 'primary',
178177
id: 'viewClient' + rowData.inum,
179178
},
180179
tooltip: `${t('messages.view_client_details')}`,
@@ -184,7 +183,7 @@ function ClientListPage({ clients, permissions, scopes, loading, dispatch }) {
184183
}
185184
if (hasPermission(permissions, CLIENT_DELETE)) {
186185
myActions.push((rowData) => ({
187-
icon: 'delete',
186+
icon: () => <DeleteOutlined />,
188187
iconProps: {
189188
color: 'secondary',
190189
id: 'deleteClient' + rowData.inum,

admin-ui/plugins/auth-server/components/Scopes/ScopeListPage.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react'
22
import MaterialTable from '@material-table/core'
3+
import { DeleteOutlined } from '@material-ui/icons'
34
import { Paper } from '@material-ui/core'
45
import { useHistory } from 'react-router-dom'
56
import { connect } from 'react-redux'
@@ -112,7 +113,6 @@ function ScopeListPage({ scopes, permissions, loading, dispatch }) {
112113
myActions.push((rowData) => ({
113114
icon: 'edit',
114115
iconProps: {
115-
color: 'primary',
116116
id: 'editScope' + rowData.inum,
117117
},
118118
tooltip: `${t('messages.edit_scope')}`,
@@ -164,7 +164,7 @@ function ScopeListPage({ scopes, permissions, loading, dispatch }) {
164164

165165
if (hasPermission(permissions, SCOPE_DELETE)) {
166166
myActions.push((rowData) => ({
167-
icon: 'delete',
167+
icon: () => <DeleteOutlined />,
168168
iconProps: {
169169
color: 'secondary',
170170
id: 'deleteScope' + rowData.inum,

admin-ui/plugins/schema/components/Person/AttributeListPage.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react'
22
import MaterialTable from '@material-table/core'
3+
import { DeleteOutlined } from '@material-ui/icons'
34
import { useHistory } from 'react-router-dom'
45
import { Paper } from '@material-ui/core'
56
import { connect } from 'react-redux'
@@ -83,7 +84,6 @@ function AttributeListPage({ attributes, permissions, loading, dispatch }) {
8384
myActions.push((rowData) => ({
8485
icon: 'edit',
8586
iconProps: {
86-
color: 'primary',
8787
id: 'editAttribute' + rowData.inum,
8888
},
8989
tooltip: `${t('tooltips.edit_attribute')}`,
@@ -95,7 +95,6 @@ function AttributeListPage({ attributes, permissions, loading, dispatch }) {
9595
myActions.push((rowData) => ({
9696
icon: 'visibility',
9797
iconProps: {
98-
color: 'primary',
9998
id: 'viewAttribute' + rowData.inum,
10099
},
101100
tooltip: `${t('tooltips.view_Attribute')}`,
@@ -133,7 +132,7 @@ function AttributeListPage({ attributes, permissions, loading, dispatch }) {
133132
}
134133
if (hasPermission(permissions, ATTRIBUTE_DELETE)) {
135134
myActions.push((rowData) => ({
136-
icon: 'delete',
135+
icon: () => <DeleteOutlined />,
137136
iconProps: {
138137
color: 'secondary',
139138
id: 'deleteAttribute' + rowData.inum,

admin-ui/plugins/services/Components/Configuration/LdapListPage.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react'
2-
import MaterialTable from '@material-table/core';
2+
import MaterialTable from '@material-table/core'
3+
import { DeleteOutlined } from '@material-ui/icons'
34
import { useHistory } from 'react-router-dom'
45
import { connect } from 'react-redux'
56
import { Badge } from 'reactstrap'
@@ -72,7 +73,6 @@ function LdapListPage({
7273
myActions.push((rowData) => ({
7374
icon: 'edit',
7475
iconProps: {
75-
color: 'primary',
7676
id: 'editLdap' + rowData.configId,
7777
},
7878
tooltip: `${t('tooltips.edit_ldap')}`,
@@ -94,7 +94,7 @@ function LdapListPage({
9494
}
9595
if (hasPermission(permissions, LDAP_DELETE)) {
9696
myActions.push((rowData) => ({
97-
icon: 'delete',
97+
icon: () => <DeleteOutlined />,
9898
iconProps: {
9999
color: 'secondary',
100100
id: 'deleteLdap' + rowData.configId,

admin-ui/plugins/services/Components/Configuration/SqlListPage.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { useState, useEffect } from 'react'
2-
import MaterialTable from '@material-table/core';
2+
import MaterialTable from '@material-table/core'
3+
import { DeleteOutlined } from '@material-ui/icons'
34
import { useHistory } from 'react-router-dom'
45
import { connect } from 'react-redux'
56
import { Paper } from '@material-ui/core'
@@ -71,7 +72,6 @@ function SqlListPage({
7172
myActions.push((rowData) => ({
7273
icon: 'edit',
7374
iconProps: {
74-
color: 'primary',
7575
id: 'editSql' + rowData.configId,
7676
},
7777
tooltip: `${t('tooltips.edit_sql')}`,
@@ -93,7 +93,7 @@ function SqlListPage({
9393
}
9494
if (hasPermission(permissions, SQL_DELETE)) {
9595
myActions.push((rowData) => ({
96-
icon: 'delete',
96+
icon: () => <DeleteOutlined />,
9797
iconProps: {
9898
color: 'secondary',
9999
id: 'deleteSql' + rowData.configId,

0 commit comments

Comments
 (0)