Skip to content

Commit 92699fa

Browse files
committed
fix: sonar issues
1 parent 2ac6e2d commit 92699fa

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

admin-ui/app/components/Notifications/index.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,13 @@ export default function Lang() {
3939
return (
4040
<div className={classes.root}>
4141
<div>
42-
<div
43-
role='button'
44-
tabindex="0"
42+
<button
4543
ref={anchorRef}
4644
className={classes.notificationBtn}
4745
onClick={handleToggle}
4846
>
4947
<NotificationsIcon style={{color: "white", width: "35px", height: "100%"}}/>
50-
</div>
48+
</button>
5149
<Popper open={open} anchorEl={anchorRef.current} role={undefined} transition disablePortal className={classes.topElm}>
5250
{({ TransitionProps, placement }) => (
5351
<Grow

admin-ui/app/components/Notifications/styles.js

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ const styles = makeStyles()((theme) => ({
2121
textTransform: 'none',
2222
padding:"2px",
2323
cursor: 'pointer',
24+
border: 'none',
25+
background: 'none',
2426
'&:active': {
2527
backgroundColor: "rgba(217, 217, 217, 0.43)",
2628
transform: 'scale(0.95)',

admin-ui/app/components/ThemeSetting/ThemeSettings.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,9 @@ export function ThemeSettings({ userInfo }) {
7676

7777
return (
7878
<React.Fragment>
79-
<div role='button' tabindex="0" onClick={toggleDrawer(true)} className={classes.settingsToggeleBtn}>
79+
<buttton onClick={toggleDrawer(true)} className={classes.settingsToggeleBtn}>
8080
<SettingsIcon style={{color: "white",width: "35px", height:"100%"}}/>
81-
</div>
81+
</buttton>
8282
<Drawer className={classes.drawerContainer} anchor={'right'} open={open} onClose={toggleDrawer(false)}>
8383
{list('right')}
8484
</Drawer>

admin-ui/app/components/ThemeSetting/styles.js

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ const styles = makeStyles()({
1616
textTransform: 'none',
1717
padding:"2px",
1818
cursor: 'pointer',
19+
border:'none',
20+
background: 'none',
1921
'&:active': {
2022
backgroundColor: "rgba(217, 217, 217, 0.43)",
2123
transform: 'scale(0.95)',

0 commit comments

Comments
 (0)