feat: fix code smells

duttarnab · duttarnab · commit da43379bd81e · 2023-07-22T12:24:59.000+05:30
diff --git a/admin-ui/app/utils/RandomHashGenerator.js b/admin-ui/app/utils/RandomHashGenerator.js
@@ -10,9 +10,9 @@ export class RandomHashGenerator {
     }
 
     static base64URLEncode(a) {
-        var str = "";
-        var bytes = new Uint8Array(a);
-        var len = bytes.byteLength;
+        let str = "";
+        let bytes = new Uint8Array(a);
+        const len = bytes.byteLength;
         for (var i = 0; i < len; i++) {
             str += String.fromCharCode(bytes[i]);
         }
@@ -29,7 +29,7 @@ export class RandomHashGenerator {
     }
 
     static generateRandomString() {
-        var array = new Uint32Array(56 / 2);
+        let array = new Uint32Array(56 / 2);
         window.crypto.getRandomValues(array);
         return Array.from(array, RandomHashGenerator.dec2hex).join('');
     }

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,9 @@ export class RandomHashGenerator {`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`static base64URLEncode(a) {`
`13`		`- var str = "";`
`14`		`- var bytes = new Uint8Array(a);`
`15`		`- var len = bytes.byteLength;`
	`13`	`+ let str = "";`
	`14`	`+ let bytes = new Uint8Array(a);`
	`15`	`+ const len = bytes.byteLength;`
`16`	`16`	`for (var i = 0; i < len; i++) {`
`17`	`17`	`str += String.fromCharCode(bytes[i]);`
`18`	`18`	`}`
`@@ -29,7 +29,7 @@ export class RandomHashGenerator {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`static generateRandomString() {`
`32`		`- var array = new Uint32Array(56 / 2);`
	`32`	`+ let array = new Uint32Array(56 / 2);`
`33`	`33`	`window.crypto.getRandomValues(array);`
`34`	`34`	`return Array.from(array, RandomHashGenerator.dec2hex).join('');`
`35`	`35`	`}`