Skip to content

net-swp cleanup #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sruffilli opened this issue Jul 21, 2024 · 1 comment · Fixed by #2510
Closed

net-swp cleanup #2434

sruffilli opened this issue Jul 21, 2024 · 1 comment · Fixed by #2510
Assignees
@sruffilli
Labels
on:modules

Comments

@sruffilli
Copy link
Collaborator

sruffilli commented Jul 21, 2024 •
edited
Loading

Module net-swp requires at least

  • Better documentation (e.g. proxy subnet requirement, cloud router handling)
  • Variables cleanup (e.g. var.addresses shouldn't be required)
  • Add service-attachment management (blocked by terraform-provider-google/#18710)
@sruffilli sruffilli self-assigned this Jul 21, 2024
@juliocc
Copy link
Collaborator

juliocc commented Aug 7, 2024

The last point was fixed by GoogleCloudPlatform/magic-modules#11107 and is available since version 5.39.0

@sruffilli sruffilli mentioned this issue Aug 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sruffilli sruffilli

Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net-swp module cleanup GoogleCloudPlatform/cloud-foundation-fabric
2 participants
@juliocc @sruffilli