feat(spanner): add instance asymmetric autoscaling options support in spanner instance resource (#12100)

Author: rahul2393

mmv1/products/spanner/Instance.yaml

@@ -228,6 +228,40 @@ properties:
               should be trying to achieve for the instance.
               This number is on a scale from 0 (no utilization) to 100 (full utilization).
 
+      - name: 'asymmetricAutoscalingOptions'
+        type: Array
+        description: |
+          Asymmetric autoscaling options for specific replicas.
+        item_type:
+          type: NestedObject
+          properties:
+            - name: 'replicaSelection'
+              type: NestedObject
+              required: true
+              properties:
+                - name: 'location'
+                  type: String
+                  required: true
+                  description: |
+                    The location of the replica to apply asymmetric autoscaling options.
+            - name: 'overrides'
+              type: NestedObject
+              required: true
+              properties:
+                - name: 'autoscalingLimits'
+                  type: NestedObject
+                  required: true
+                  properties:
+                    - name: 'minNodes'
+                      type: Integer
+                      required: true
+                      description: |
+                        The minimum number of nodes for this specific replica.
+                    - name: 'maxNodes'
+                      type: Integer
+                      required: true
+                      description: |
+                        The maximum number of nodes for this specific replica.
   - name: 'edition'
     type: Enum
     description: |

mmv1/templates/terraform/encoders/spanner_instance_update.go.tmpl

@@ -46,6 +46,9 @@ if d.HasChange("autoscaling_config") {
 		if d.HasChange("autoscaling_config.0.autoscaling_targets.0.storage_utilization_percent") {
 			updateMask = append(updateMask, "autoscalingConfig.autoscalingTargets.storageUtilizationPercent")
 		}
+		if d.HasChange("autoscaling_config.0.asymmetric_autoscaling_options") {
+			updateMask = append(updateMask, "autoscalingConfig.asymmetricAutoscalingOptions")
+		}
 	}
 }
 newObj["fieldMask"] = strings.Join(updateMask, ",")

mmv1/third_party/terraform/services/spanner/resource_spanner_instance_test.go

@@ -312,14 +312,61 @@ func TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate(t *testing
 	})
 }
 
+func TestAccSpannerInstance_basicWithAsymmetricAutoscalingConfigsUpdate(t *testing.T) {
+	displayName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckSpannerInstanceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccSpannerInstance_main(displayName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("google_spanner_instance.main", "state"),
+				),
+			},
+			{
+				ResourceName:            "google_spanner_instance.main",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"labels", "terraform_labels"},
+			},
+			{
+				Config: testAccSpannerInstance_basicWithAsymmetricAutoscalingConfigsUpdate(displayName, 1, 10),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("google_spanner_instance.main", "state"),
+				),
+			},
+			{
+				ResourceName:            "google_spanner_instance.main",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"labels", "terraform_labels"},
+			},
+			{
+				Config: testAccSpannerInstance_basicWithAsymmetricAutoscalingConfigsUpdate(displayName, 3, 5),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("google_spanner_instance.main", "state"),
+				),
+			},
+			{
+				ResourceName:            "google_spanner_instance.main",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"labels", "terraform_labels"},
+			},
+		},
+	})
+}
+
 func testAccSpannerInstance_basic(name string) string {
 	return fmt.Sprintf(`
 resource "google_spanner_instance" "basic" {
   name         = "%s"
   config       = "regional-us-central1"
   display_name = "%s-dname"
   num_nodes    = 1
-  edition      = "ENTERPRISE" 
+  edition      = "ENTERPRISE"
 }
 `, name, name)
 }
@@ -458,3 +505,63 @@ resource "google_spanner_instance" "basic" {
 }
 `, name, name, maxNodes, minNodes, cupUtilizationPercent, storageUtilizationPercent)
 }
+
+func testAccSpannerInstance_main(name string) string {
+	return fmt.Sprintf(`
+resource "google_spanner_instance" "main" {
+  name         = "%s"
+  config       = "nam-eur-asia3"
+  display_name = "%s"
+  num_nodes    = 1
+  edition      = "ENTERPRISE_PLUS"
+}
+`, name, name)
+}
+
+func testAccSpannerInstance_basicWithAsymmetricAutoscalingConfigsUpdate(name string, minNodes, maxNodes int) string {
+	return fmt.Sprintf(`
+provider "google" {
+  alias                 = "user-project-override"
+  user_project_override = true
+}
+
+resource "google_spanner_instance" "main" {
+  provider     = google.user-project-override
+  name         = "%s"
+  config       = "nam-eur-asia3"
+  display_name =  "%s"
+  autoscaling_config {
+    autoscaling_limits {
+      max_nodes = 3
+      min_nodes = 1
+    }
+    autoscaling_targets {
+      high_priority_cpu_utilization_percent = 75
+      storage_utilization_percent           = 90
+    }
+    asymmetric_autoscaling_options {
+      replica_selection {
+        location = "europe-west1"
+      }
+      overrides {
+        autoscaling_limits {
+          min_nodes = 3
+          max_nodes = 30
+        }
+      }
+    }
+    asymmetric_autoscaling_options {
+      replica_selection {
+        location = "asia-east1"
+      }
+      overrides {
+        autoscaling_limits {
+          min_nodes = %d
+          max_nodes = %d
+        }
+      }
+    }
+  }
+  edition = "ENTERPRISE_PLUS"
+}`, name, name, minNodes, maxNodes)
+}