Skip to content

Commit 228ed9f

Browse files
authored
Apply suggestions from code review
1 parent c79d42b commit 228ed9f

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

mmv1/third_party/terraform/services/colab/resource_colab_schedule_test.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ func TestAccColabSchedule_update_state(t *testing.T) {
180180
func testAccColabSchedule_full(context map[string]interface{}) string {
181181
return acctest.Nprintf(`
182182
resource "google_colab_runtime_template" "my_runtime_template" {
183-
name = ""
183+
name = "tf-test-runtime-template%{random_suffix}"
184184
display_name = "Runtime template"
185185
location = "us-central1"
186186
@@ -242,7 +242,7 @@ resource "google_storage_bucket_object" "notebook" {
242242
}
243243
244244
resource "google_colab_schedule" "schedule" {
245-
display_name = "Notebook Schedule full"
245+
display_name = "tf-test-schedule%{random_suffix}"
246246
location = "%{location}"
247247
allow_queueing = true
248248
max_concurrent_run_count = 2
@@ -276,7 +276,7 @@ resource "google_colab_schedule" "schedule" {
276276
func testAccColabSchedule_paused(context map[string]interface{}) string {
277277
return acctest.Nprintf(`
278278
resource "google_colab_runtime_template" "my_runtime_template" {
279-
name = ""
279+
name = "tf-test-runtime-template%{random_suffix}"
280280
display_name = "Runtime template"
281281
location = "us-central1"
282282
@@ -338,7 +338,7 @@ resource "google_storage_bucket_object" "notebook" {
338338
}
339339
340340
resource "google_colab_schedule" "schedule" {
341-
display_name = "Notebook Schedule full"
341+
display_name = "tf-test-schedule%{random_suffix}"
342342
location = "%{location}"
343343
allow_queueing = true
344344
max_concurrent_run_count = 2
@@ -374,7 +374,7 @@ resource "google_colab_schedule" "schedule" {
374374
func testAccColabSchedule_active(context map[string]interface{}) string {
375375
return acctest.Nprintf(`
376376
resource "google_colab_runtime_template" "my_runtime_template" {
377-
name = ""
377+
name = "tf-test-runtime-template%{random_suffix}"
378378
display_name = "Runtime template"
379379
location = "us-central1"
380380
@@ -436,7 +436,7 @@ resource "google_storage_bucket_object" "notebook" {
436436
}
437437
438438
resource "google_colab_schedule" "schedule" {
439-
display_name = "Notebook Schedule full"
439+
display_name = "tf-test-schedule%{random_suffix}"
440440
location = "%{location}"
441441
allow_queueing = true
442442
max_concurrent_run_count = 2
@@ -472,7 +472,7 @@ resource "google_colab_schedule" "schedule" {
472472
func testAccColabSchedule_update(context map[string]interface{}) string {
473473
return acctest.Nprintf(`
474474
resource "google_colab_runtime_template" "my_runtime_template" {
475-
name = ""
475+
name = "tf-test-runtime-template%{random_suffix}"
476476
display_name = "Runtime template"
477477
location = "us-central1"
478478
@@ -534,7 +534,7 @@ resource "google_storage_bucket_object" "notebook" {
534534
}
535535
536536
resource "google_colab_schedule" "schedule" {
537-
display_name = "Notebook Schedule updated"
537+
display_name = "tf-test-schedule-updated%{random_suffix}"
538538
location = "%{location}"
539539
allow_queueing = false
540540
max_concurrent_run_count = 1

0 commit comments

Comments
 (0)